From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Suman Ghosh <sumang@marvell.com>
Subject: Re: [net PATCH v2] octeontx2-af: Unlock contexts in the queue context
 cache in case of fault detection
Thread-Topic: [net PATCH v2] octeontx2-af: Unlock contexts in the queue
 context cache in case of fault detection
Thread-Index: AQHZSCt8Otcs/tshykKY8z2XKhbm6Q==
Date:   Fri, 24 Feb 2023 08:39:20 +0000
Message-ID: <BY3PR18MB470774ABED5E4E22DAA4535EA0A89@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230223110125.2172509-1-saikrishnag@marvell.com>
 <Y/dnNRD4Gpl0n2GQ@corigine.com>
In-Reply-To: <Y/dnNRD4Gpl0n2GQ@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zcQpyU79dor1R2aVbqz49/QRVbIJmxrlvWrUuuQgKCl7uNxHISfI52Q4HDsq?=
 =?us-ascii?Q?XHpwfeHO8qFoyN2NZWhobyUYN4uxG2lmV3IJZp/IdEQGGUZa6fkRzbRap2Eq?=
 =?us-ascii?Q?7a4YjtT/bJHc8FoLHA4hfkejZAjhfnsBeYzA5qyIboDP0vLKrUwrHjzHZnlR?=
 =?us-ascii?Q?BZLiY1+F/aAfG8/wMXrLT7FX1Vr8okAb3q/FvIxmNRa1Cxe8mZJb8oWK8Ku/?=
 =?us-ascii?Q?z7B9M/ehqvca8S9AXeFy38xIkgcR3iKba5FWEGYZnH4ehbOZM3NAoiVo6/OH?=
 =?us-ascii?Q?O18D9+5wJIdTe655KYOqUv8AyTKXNZUBM80Zd3qqKA7VqOG3vrp/5ngJy8Ax?=
 =?us-ascii?Q?QC+dHqEd3cbmThxHeYh1gN5lUyv1mj1cmZA4L+p4lYTORD+dq0hRtH5StbxD?=
 =?us-ascii?Q?39kf1vzfp9McAYGxgDabPgAraXpbJK/Xvaigp2MMs/O1lUD5uaVyoC+6PwHt?=
 =?us-ascii?Q?rXtNzpB0+sH00olpo7GEy1UElFPrzSAvn+iT9CzxR2axptMS2s1r8Y5Brfh4?=
 =?us-ascii?Q?HI0oC0BGfNWW4Uh4Zm7cAdjVgHO6fOwS1OewznuGBV+b53L83VRTi9kQDT03?=
 =?us-ascii?Q?PCfMNATH4P5HEQd8T4gCYb5xk1VXjpRoJpOhclFWjMv55kxq15650lCNXQT/?=
 =?us-ascii?Q?XDiQ7/esgA0/6o6ieiL/SMO6rT85+AO7Q/c3Jv5Q1sr6nGiBbD9tKMpDt3l4?=
 =?us-ascii?Q?DZO06GhaU92SjpAwfB7J4QBKLgS2W3NSe0yor5b0FvkVrc5M5bGXCl09zQGg?=
 =?us-ascii?Q?+wZsqv2fpqAILBsItsQcwT3Gsm+GJH2OQtcIGlaMoLTlz7ar2pEOqEP4/kQS?=
 =?us-ascii?Q?11ysEEZhabHSAugvtKBFeLug/zJs/TmRzkykkgUx7awMz0akz0XBJN2Y0pvP?=
 =?us-ascii?Q?xGN5ClplfL7qVp/M+/1H1qHvk/fR/G9ePJC9FrtKKpoEyynlFIA4b7Vul6wt?=
 =?us-ascii?Q?lz6v1KcMDHnUj0/O6cc+VCyWuOJT9LWv+MW21mvFMColbNQ7sv4ORgn1hav7?=
 =?us-ascii?Q?NgndbubhNhoCPz6R3JhWDHuZLPhjjk1kRou6Yl2JBsDb2gGV1cnzDJ9oNpuB?=
 =?us-ascii?Q?gacSnyGKv7TkWyTt5tsXMuR8zJnf/eVGNF0nJzK6ljYnQRYmqm5D+3pGidq4?=
 =?us-ascii?Q?3FT6X1+SXFiccBIaCWS8JkwDUkzXBG/HJxU7hq7j4sPRxTV5vzBhChQ9SofI?=
 =?us-ascii?Q?YzxysF0pZqZ4czTdDy/hbdy55zuvdCpjFkVDfYiGiuxJqkOKxKZ1uR7pXZ6A?=
 =?us-ascii?Q?hGE65Iv6o98ZBXKc8hQWsxd69APwdZ0U26UmNpcuCsp7s2KR0IfpbfCn69a6?=
 =?us-ascii?Q?K+45GCxjTYPzpacraCz0WOLGa+9SMUNgWqHRsjai0FY9JQfQs2YCOdem4TGA?=
 =?us-ascii?Q?PEPL5dGQONoTjNS/7+Rnn+35xPuKLrLrCia0Jx5eR9zJlHvxyjjGJxZw2pey?=
 =?us-ascii?Q?PYBYxoGmtpDdUoBGbIXPBy3ua/sbG3fZIQNg69phLKxTNZGALKxOXXwoYosE?=
 =?us-ascii?Q?FFmn35GwpIzzu/oVgmRcYJcQnMf3Y4n3z9Z1Un4A6CheO9b7QjOmpyLTJf5K?=
 =?us-ascii?Q?+cxsOaPfdEjbZuJ6c4KVQ4lTKyKTo06IGql0CCZd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 317f067a-a235-420e-f31f-08db16429f72
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2023 08:39:20.1664
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7gSew6aUVpYMEqQC7zlbFqWetEyjQW59F1RgnUMA0Nb3Tg/3fxfwQy9K3gSMI/XedS6j8HP6RWDO44abkEijfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR18MB4910
X-Proofpoint-GUID: gQW0M_qg7ua5S9oO8U2dVbyTRe7XUIxn
X-Proofpoint-ORIG-GUID: gQW0M_qg7ua5S9oO8U2dVbyTRe7XUIxn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-24_04,2023-02-23_01,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Simon,

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Thursday, February 23, 2023 6:47 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>; Suman Ghosh
> <sumang@marvell.com>
> Subject: Re: [net PATCH v2] octeontx2-af: Unlock contexts in the queue
> context cache in case of fault detection
>=20
>=20
> ----------------------------------------------------------------------
> On Thu, Feb 23, 2023 at 04:31:25PM +0530, Sai Krishna wrote:
> > From: Suman Ghosh <sumang@marvell.com>
> >
> > NDC caches contexts of frequently used queue's (Rx and Tx queues)
> > contexts. Due to a HW errata when NDC detects fault/poision while
> > accessing contexts it could go into an illegal state where a cache
> > line could get locked forever. To makesure all cache lines in NDC are
> > available for optimum performance upon fault/lockerror/posion errors
> > scan through all cache lines in NDC and clear the lock bit.
> >
> > Fixes: 4a3581cd5995 ("octeontx2-af: NPA AQ instruction enqueue
> > support")
> > Signed-off-by: Suman Ghosh <sumang@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > index 389663a13d1d..6508f25b2b37 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > @@ -884,6 +884,12 @@ int rvu_cpt_lf_teardown(struct rvu *rvu, u16
> > pcifunc, int blkaddr, int lf,  int rvu_cpt_ctx_flush(struct rvu *rvu,
> > u16 pcifunc);  int rvu_cpt_init(struct rvu *rvu);
> >
> > +/* NDC APIs */
> > +#define NDC_MAX_BANK(rvu, blk_addr) (rvu_read64(rvu, \
> > +					blk_addr, NDC_AF_CONST) & 0xFF)
> > +#define NDC_MAX_LINE_PER_BANK(rvu, blk_addr) ((rvu_read64(rvu, \
> > +					blk_addr, NDC_AF_CONST) &
> 0xFFFF0000) >> 16)
>=20
> Perhaps not appropriate to include as part of a fix, as NDC_MAX_BANK is
> being moved from elsewhere, but I wonder if this might be more cleanly
> implemented using FIELD_GET().

We will modify and send a separate patch for all the possible macros that c=
an be replaced by FIELD_GET().=20

>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > index 1729b22580ce..bc6ca5ccc1ff 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > @@ -694,6 +694,7 @@
> >  #define NDC_AF_INTR_ENA_W1S		(0x00068)
> >  #define NDC_AF_INTR_ENA_W1C		(0x00070)
> >  #define NDC_AF_ACTIVE_PC		(0x00078)
> > +#define NDC_AF_CAMS_RD_INTERVAL		(0x00080)
> >  #define NDC_AF_BP_TEST_ENABLE		(0x001F8)
> >  #define NDC_AF_BP_TEST(a)		(0x00200 | (a) << 3)
> >  #define NDC_AF_BLK_RST			(0x002F0)
> > @@ -709,6 +710,8 @@
> >  		(0x00F00 | (a) << 5 | (b) << 4)
> >  #define NDC_AF_BANKX_HIT_PC(a)		(0x01000 | (a) << 3)
> >  #define NDC_AF_BANKX_MISS_PC(a)		(0x01100 | (a) << 3)
> > +#define NDC_AF_BANKX_LINEX_METADATA(a, b) \
> > +		(0x10000 | (a) << 3 | (b) << 3)
>=20
> It looks a little odd that both a and b are shifted by 3 bits.
> If it's intended then perhaps it would be clearer to write this as:
>=20
> #define NDC_AF_BANKX_LINEX_METADATA(a, b) \
> 		(0x10000 | ((a) | (b)) << 3)

will send v3 patch.

Thanks,
Sai

>=20
> >
> >  /* LBK */
> >  #define LBK_CONST			(0x10ull)
> > --
> > 2.25.1
> >