Date:   Fri, 24 Feb 2023 10:07:24 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna Gajula <saikrishnag@marvell.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Suman Ghosh <sumang@marvell.com>
Subject: Re: [net PATCH v2] octeontx2-af: Unlock contexts in the queue
 context cache in case of fault detection
Message-ID: <Y/h+TH9WTWOVaSHj@corigine.com>
References: <20230223110125.2172509-1-saikrishnag@marvell.com>
 <Y/dnNRD4Gpl0n2GQ@corigine.com>
 <BY3PR18MB470774ABED5E4E22DAA4535EA0A89@BY3PR18MB4707.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BY3PR18MB470774ABED5E4E22DAA4535EA0A89@BY3PR18MB4707.namprd18.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4Ey7Kddp6tSESfr7NxPawKSYDJoosOcCoBcJKa3GGpcFfkc2M7jiOuAom0+C?=
 =?us-ascii?Q?hDVdMgHN7aNZwqzefoYrx5AuhVwjOAXFAmzfK4GdT5gogjD7gIYUzjjw9+4m?=
 =?us-ascii?Q?+35LSKcO+iN24m79GHrVTE1psq9Oi3MPCmWCrUSE2TDo60vfNqKU+nfG47Kx?=
 =?us-ascii?Q?RlmxoUEyLZR7RjNuVsc3IuVbrbNw5P/o6LtRFKDWJsGH4tRUsFbJDHG653UY?=
 =?us-ascii?Q?OxWSTb2QPNTYBQ5NK1bMIEkhHLLBCVieqgl0YqA2yd7PRELTABtq6S7/4Z6D?=
 =?us-ascii?Q?ShW9ay/7NHnyj5M+qUu3JL9yLSAmDKCYDmP3lo+y3Om/E0ZexklNGBpE5t95?=
 =?us-ascii?Q?5MXXiCOKKacgiCqqDn/5ydBng5+RXrjqD82wepXR6o4aY5RP+U6ZSXXqGoLZ?=
 =?us-ascii?Q?JtyRtaSpcM5wnbOYXM23cbn7z+7RlmXiz9I/DyXgxTL1xKxINBG2GPLUwutY?=
 =?us-ascii?Q?hyTMaHkUtqTFL4K1IN22FCXXuvtXjp3cddg64b8EkfOI+9Q0xKz29tCQ3ULk?=
 =?us-ascii?Q?4FjkLPq9xzLGSQn6rodOGu8bDr0vqyCeRQQYLRTAs7R2j21NTPMgm1DZ3tLZ?=
 =?us-ascii?Q?psMYV1TrDfflds2mOiY6lbqpgris8JdTv32U1g52Ig8dRXlyIzMHivupIQyw?=
 =?us-ascii?Q?OTnJ9YvFzVk2xKrybCgv5JIakoLGaNG/VRO7KbYZIsP33U6Muhil5KKc5M2T?=
 =?us-ascii?Q?twJpiFCLpwU5jo6Tu4aGP99afYWD0+9fA7ZfuX48f1XzFB0kIHiOWuQEMbvD?=
 =?us-ascii?Q?Y+sqAr1KALc8J3qw5mgldKhTDwkGgzW7MEvuqvi1+LWuD94RhW05c9o9l8UD?=
 =?us-ascii?Q?6qiOvaEOZ73WkPSMRFT2BSksnpPuFg3bM96vy9IgGNZRV++QDgLY1tC395jj?=
 =?us-ascii?Q?4OB2QG9aCBbvMNmM802WcYIVolygLmgLn2ua/64VOoXwiwLGLIvieQ3wsX5o?=
 =?us-ascii?Q?xZjDjQC4bNjNrJ42HIHZRjWocUb9V969MoilAfqoT7tC/HVCVFc1Lu2zqs3Z?=
 =?us-ascii?Q?G4RMAEMSNXYqa8HxndC2kRCOb/QpX87txmdxq4qFIFCo6BXXzv0GtNukO1Lx?=
 =?us-ascii?Q?tWZQbpreX9X4XrfGxQ6v3/LMAZNG49yIJFAKOynqey+LszWewxHgPm/EI1PC?=
 =?us-ascii?Q?dyPBhBxptAfbqJcWa/JrQOYSYHFYIJaJ3Jy0TU+wOEJsyySF/dLcwwFlaERU?=
 =?us-ascii?Q?jmzE9aEhufM4wUCu7aHv1A97OrFwckUpbt2dxsZizIcPfcHaLmqqhnJyU1l3?=
 =?us-ascii?Q?E5C3XX+s/Gvv9GRd7PQuUQoCkDEx5YL9usBIZ5FgW/fUx7Pt0mIJLjDH0XIB?=
 =?us-ascii?Q?tQ8RS8vpNOpoF5DMnGCoDYrYamOtv2mZs6pBzsHJA07u0CHNGn8OCaM4HuAn?=
 =?us-ascii?Q?06iRYGc2tXxoy+Kerr/Oi0X9klc/W9C5qaQGcMBR/AkT3TEPcepVZbyM5jZi?=
 =?us-ascii?Q?0ecW/8vzeBob7v5oDE8Q63acAmaeArvr3IX4RozWB9bx+MmZSMEj6J2hqhk4?=
 =?us-ascii?Q?JaU8U/Ndk3wOfNl4LUOaB0eIT3kvkllugYcXOpMGwfCHuc7pFOaNwVrsVJiM?=
 =?us-ascii?Q?251np4G1Uu36YSnIl3kdJNeKXlEhwREKAtmhWM++XDeTiO285GSEWzIo2E+K?=
 =?us-ascii?Q?wS0R3/niT9Wm0aMpMed86lBsLsX4EKJ7FABW7HVzYLRA/yDPIWo4OpibdpvF?=
 =?us-ascii?Q?G0/A7A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 507b284d-5af1-4b27-64bb-08db16468f18
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:07:30.9194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KBSya8vgZ2147TY4lCuN/PHmalNYSUKj+MXsSsmWmNU8ZhoOWIT+CSyJms35RlbuxTUygbNyc+Mz/BsoEjm8DcMQ6chiv9L/chq28tmYO08=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3717
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 24, 2023 at 08:39:20AM +0000, Sai Krishna Gajula wrote:
> Hi Simon,
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine.com>
> > Sent: Thursday, February 23, 2023 6:47 PM
> > To: Sai Krishna Gajula <saikrishnag@marvell.com>
> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> > pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> > Sunil Kovvuri Goutham <sgoutham@marvell.com>; Suman Ghosh
> > <sumang@marvell.com>
> > Subject: Re: [net PATCH v2] octeontx2-af: Unlock contexts in the queue
> > context cache in case of fault detection
> > 
> > 
> > ----------------------------------------------------------------------
> > On Thu, Feb 23, 2023 at 04:31:25PM +0530, Sai Krishna wrote:
> > > From: Suman Ghosh <sumang@marvell.com>
> > >
> > > NDC caches contexts of frequently used queue's (Rx and Tx queues)
> > > contexts. Due to a HW errata when NDC detects fault/poision while
> > > accessing contexts it could go into an illegal state where a cache
> > > line could get locked forever. To makesure all cache lines in NDC are
> > > available for optimum performance upon fault/lockerror/posion errors
> > > scan through all cache lines in NDC and clear the lock bit.
> > >
> > > Fixes: 4a3581cd5995 ("octeontx2-af: NPA AQ instruction enqueue
> > > support")
> > > Signed-off-by: Suman Ghosh <sumang@marvell.com>
> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > 
> > ...
> > 
> > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > > index 389663a13d1d..6508f25b2b37 100644
> > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> > > @@ -884,6 +884,12 @@ int rvu_cpt_lf_teardown(struct rvu *rvu, u16
> > > pcifunc, int blkaddr, int lf,  int rvu_cpt_ctx_flush(struct rvu *rvu,
> > > u16 pcifunc);  int rvu_cpt_init(struct rvu *rvu);
> > >
> > > +/* NDC APIs */
> > > +#define NDC_MAX_BANK(rvu, blk_addr) (rvu_read64(rvu, \
> > > +					blk_addr, NDC_AF_CONST) & 0xFF)
> > > +#define NDC_MAX_LINE_PER_BANK(rvu, blk_addr) ((rvu_read64(rvu, \
> > > +					blk_addr, NDC_AF_CONST) &
> > 0xFFFF0000) >> 16)
> > 
> > Perhaps not appropriate to include as part of a fix, as NDC_MAX_BANK is
> > being moved from elsewhere, but I wonder if this might be more cleanly
> > implemented using FIELD_GET().
> 
> We will modify and send a separate patch for all the possible macros that can be replaced by FIELD_GET(). 

Thanks, much appreciated.

> > ...
> > 
> > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > > index 1729b22580ce..bc6ca5ccc1ff 100644
> > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_reg.h
> > > @@ -694,6 +694,7 @@
> > >  #define NDC_AF_INTR_ENA_W1S		(0x00068)
> > >  #define NDC_AF_INTR_ENA_W1C		(0x00070)
> > >  #define NDC_AF_ACTIVE_PC		(0x00078)
> > > +#define NDC_AF_CAMS_RD_INTERVAL		(0x00080)
> > >  #define NDC_AF_BP_TEST_ENABLE		(0x001F8)
> > >  #define NDC_AF_BP_TEST(a)		(0x00200 | (a) << 3)
> > >  #define NDC_AF_BLK_RST			(0x002F0)
> > > @@ -709,6 +710,8 @@
> > >  		(0x00F00 | (a) << 5 | (b) << 4)
> > >  #define NDC_AF_BANKX_HIT_PC(a)		(0x01000 | (a) << 3)
> > >  #define NDC_AF_BANKX_MISS_PC(a)		(0x01100 | (a) << 3)
> > > +#define NDC_AF_BANKX_LINEX_METADATA(a, b) \
> > > +		(0x10000 | (a) << 3 | (b) << 3)
> > 
> > It looks a little odd that both a and b are shifted by 3 bits.
> > If it's intended then perhaps it would be clearer to write this as:
> > 
> > #define NDC_AF_BANKX_LINEX_METADATA(a, b) \
> > 		(0x10000 | ((a) | (b)) << 3)
> 
> will send v3 patch.

Likewise, thanks.