Message-ID: <22948c58-d9df-1326-a849-4278d14f76b5@gmail.com>
Date:   Fri, 24 Feb 2023 17:35:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] net: tls: fix possible info leak in
 tls_set_device_offload()
To:     Sabrina Dubroca <sd@queasysnail.net>
Cc:     borisp@nvidia.com, john.fastabend@gmail.com, kuba@kernel.org,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230223090508.443157-1-hbh25y@gmail.com> <Y/dK6OoNpYswIqrD@hog>
 <310391ea-7c71-395e-5dcb-b0a983e6fc93@gmail.com>
 <04c4d6ee-f893-5248-26cf-2c6d1c9b3aa5@gmail.com> <Y/ht6gQL+u6fj3dG@hog>
Content-Language: en-US
From:   Hangyu Hua <hbh25y@gmail.com>
In-Reply-To: <Y/ht6gQL+u6fj3dG@hog>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/2/2023 15:57, Sabrina Dubroca wrote:
> 2023-02-24, 11:33:29 +0800, Hangyu Hua wrote:
>> On 24/2/2023 11:07, Hangyu Hua wrote:
>>> On 23/2/2023 19:15, Sabrina Dubroca wrote:
>>>> 2023-02-23, 17:05:08 +0800, Hangyu Hua wrote:
>>>>> After tls_set_device_offload() fails, we enter tls_set_sw_offload(). But
>>>>> tls_set_sw_offload can't set cctx->iv and cctx->rec_seq to NULL
>>>>> if it fails
>>>>> before kmalloc cctx->iv. This may cause info leak when we call
>>>>> do_tls_getsockopt_conf().
>>>>
>>>> Is there really an issue here?
>>>>
>>>> If both tls_set_device_offload and tls_set_sw_offload fail,
>>>> do_tls_setsockopt_conf will clear crypto_{send,recv} from the context.
>>>> Then the TLS_CRYPTO_INFO_READY in do_tls_getsockopt_conf will fail, so
>>>> we won't try to access iv or rec_seq.
>>>>
>>>
>>> My bad. I forget memzero_explicit. Then this is harmless. But I still
>>> think it is better to set them to NULL like tls_set_sw_offload's error
>>> path because we don't know there are another way to do this(I will
>>> change the commit log). What do you think?
> 
> Yes, I guess for consistency between functions it would be ok.
> 
>> Like a rare case, there is a race condition between
>> do_tls_getsockopt_conf and do_tls_setsockopt_conf while the previous
>> condition is met. TLS_CRYPTO_INFO_READY(crypto_info) is not
>> protected by lock_sock in do_tls_getsockopt_conf. It's just too
>> difficult to satisfy both conditions at the same time.
> 
> Ugh, thanks for noticing this. We should move the lock_sock in
> getsockopt before TLS_CRYPTO_INFO_READY. Do you want to write that
> patch?
> 
> Thanks.
> 

I see. I will make a new patch to fix the race and send v2 of this.

Thanks,
Hangyu