Message-ID: <7cbd979d-2126-2b8e-35d9-14e4f9681ea8@linaro.org>
Date:   Fri, 24 Feb 2023 10:59:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: max98363: add soundwire amplifier
 driver
To:     =?UTF-8?B?4oCcUnlhbg==?= <ryan.lee.analog@gmail.com>,
        lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, rf@opensource.cirrus.com,
        ckeepax@opensource.cirrus.com,
        pierre-louis.bossart@linux.intel.com, herve.codina@bootlin.com,
        wangweidong.a@awinic.com, james.schulman@cirrus.com,
        ajye_huang@compal.corp-partner.google.com, shumingf@realtek.com,
        povik+lin@cutebit.org, flatmax@flatmax.com,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        robh+dt@kernel.org, devicetree@vger.kernel.org,
        ryans.lee@analog.com
References: <20230224010814.504016-1-ryan.lee.analog@gmail.com>
 <20230224010814.504016-2-ryan.lee.analog@gmail.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230224010814.504016-2-ryan.lee.analog@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 24/02/2023 02:08, “Ryan wrote:
> From: Ryan Lee <ryans.lee@analog.com>

Thank you for your patch. There is something to discuss/improve.

Your patch is corrupted because you modified it after creating it. It
won't apply correctly and won't work. The bot's response with error is
about this.

Except broken patch, here are some more comments:

> 
> This patch adds dt-bindings information for Analog Devices MAX98363

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> SoundWire Amplifier.
> 

Subject: drop driver. Bindings are about hardware, not drivers.

> Signed-off-by: Ryan Lee <ryans.lee@analog.com>
> ---
>  .../bindings/sound/adi,max98363.yaml          | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/adi,max98363.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> new file mode 100644
> index 000000000000..fda571d04a64
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/adi,max98363.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX98363 SoundWire Amplifier
> +
> +maintainers:
> +  - Ryan Lee <ryans.lee@analog.com>
> +
> +description:
> +  The MAX98363 is a SoundWire input Class D mono amplifier that
> +  supports MIPI SoundWire v1.2-compatible digital interface for
> +  audio and control data.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,max98363
> +
> +  reg:
> +    maxItems: 1
> +    description: Peripheral-device unique ID decoded from pin
> +
> +  vdd-supply:
> +    description:
> +      A 2.5V to 5.5V supply that powers up the VDD pin.
> +
> +  dvddio-supply:
> +    description:
> +      A 1.7V or 1.9V supply that powers up the DVDDIO pin.
> +      This property is only needed for MAX98363A/B.

It's not a DAI?

> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +  - dvddio-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>

Drop the header, you do not use it.

> +    soundwire {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        max98363: amplifier@3 {

also drop label (max98363).

> +            compatible = "adi,max98363";
> +            reg = <0x3>;
> +            vdd-supply = <&regulator_vdd>;
> +            dvddio-supply = <&regulator_1v8>;
> +        };
> +    };

Best regards,
Krzysztof