From:   <Shravan.Chippa@microchip.com>
To:     <sakari.ailus@iki.fi>
CC:     <Conor.Dooley@microchip.com>, <paul.j.murphy@intel.com>,
        <daniele.alessandrelli@intel.com>, <mchehab@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
        <kernel@pengutronix.de>, <festevam@gmail.com>, <linux-imx@nxp.com>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <jacopo.mondi@ideasonboard.com>, <Prakash.Battu@microchip.com>
Subject: RE: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Thread-Topic: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Thread-Index: AQHZO3ug43tURBtLfk+08iGSApZCqq7axSqAgAAMYgCAAAE3gIAAAM8AgAADkHCAABSwAIADCyOw
Date:   Fri, 24 Feb 2023 10:02:51 +0000
Message-ID: <PH0PR11MB5611BB17A5DFAB0645D8DEB781A89@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20230208050915.1958183-1-shravan.chippa@microchip.com>
 <20230208050915.1958183-4-shravan.chippa@microchip.com>
 <Y/Xc9RCmO8P8eKtL@valkosipuli.retiisi.eu> <Y/XnWOomz2N9fCvc@wendy>
 <Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu>
 <Y/XpClyi9KMtLKcF@valkosipuli.retiisi.eu>
 <PH0PR11MB5611D8EE3F896FC0BE9A842E81AA9@PH0PR11MB5611.namprd11.prod.outlook.com>
 <Y/X9YiLJxDfLPNUX@valkosipuli.retiisi.eu>
In-Reply-To: <Y/X9YiLJxDfLPNUX@valkosipuli.retiisi.eu>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0bc9PDrtBN96ksQYS/+hwXgJ00cR5G8aBYnn+sMQDv5z1cw5XlWIMUZRYqds?=
 =?us-ascii?Q?BWVtEeXN/z0lj1wt20eE52dPj0SDnEs8v7MQf8Jjv/Vd8Qp1hhSE8U5T2QH3?=
 =?us-ascii?Q?uTUVPEfbqO0y0ht9RlOXJEFyPJoQRFE0Nnvq6SDsZ0rDBUUzBZ6weUgeGHW9?=
 =?us-ascii?Q?i2hMLWg8BWWXFLibQF6wZNWwpJpbBV2ffa8yhU1bw3JpJUYU6lfgQlB3owuj?=
 =?us-ascii?Q?3KAZA3BokXZvcK7shh59jqN74/ZkiC8x8kLVfmVY2rK0TdN7Jr+flIsZ4+LM?=
 =?us-ascii?Q?uhiMV0h8C6Gq+a+0Ph6RHJhXdHdg8Fo+j1dL7omA4MnJxuEwcFYlkR0jpEw9?=
 =?us-ascii?Q?mz+7UrnHq92Ac0sMcvTT6h65uPUwtZRp4URZkWi2reilmZtAGNcYsxs6YUYG?=
 =?us-ascii?Q?kwiDhDYWBYC8b6yhVkcPEdn8WZZKwjhGobUAjaqVIEk2rdd1YWYQ/ujcaTOf?=
 =?us-ascii?Q?CyMT0yVkHqMsulBd58JexjsGcLNEEKkxibETAi9PFO3e7cDWPGR8ix20Tzdk?=
 =?us-ascii?Q?LBMg0KtaNOleumvzGtrpzcpGfZtFXrtK9FvNJuD++3R+7lcln+zYxDWjnUvT?=
 =?us-ascii?Q?TTqOoJIfn9PnYnwjHq39yMtK0v6/Ch51dAUGq/rNxYmJdEij6PNRmF4XFlgK?=
 =?us-ascii?Q?lZQ6oNbi/PJ51Jdc22vCC0kyLhzdMnY7sGJO9GyM53FFFLX4ZPh29pAgjQvb?=
 =?us-ascii?Q?HB13h8fJfkIiL9fEPeVPdgKcKDvlvkQ27sxEJXC8vg9vf2Q506ykz/QkRUnf?=
 =?us-ascii?Q?7jkcp4vq407Vf6n1lxemAuK3NbR05KYUWQosueMSkORKyBEva5hq79ogtoFk?=
 =?us-ascii?Q?4nPtH+MzleHPp1vxAF13nkcdXVt6QraYHBgXHpHittiKOpAIQZtKMZNJkR0z?=
 =?us-ascii?Q?1VUvIrqkoDcL2LNKXo3ubTrdvAfYQONm1biFHtsRFB7Xze7BDZrqJF+wxdej?=
 =?us-ascii?Q?Am4GHuQHq+9PWI3M5FvFicGLp08ar/ga6JhDjTr2WXM7HnrFxHeN/r2WSuIb?=
 =?us-ascii?Q?s3lKR4S1yL3TAhSgoN4omNhFiUY931yv/D6xF6VFMcfLu3QsTPUp1pofuXLQ?=
 =?us-ascii?Q?oAVWTCwFkh/zkF8459XNR4XZa3fxrIiZeT5RJUfOxsm05AOZQ9e0SVd6EDgr?=
 =?us-ascii?Q?72YCoWYBJ3MMqcxwOTY9sl8W7mhKMF1/wdNc8l+P/5UyMEK0/u+2DmKucMCh?=
 =?us-ascii?Q?mR+ym3CUHdSW0NMeB/DeEm7Is0ePyzbMJ4s21MAu53lJhWyh/h6R9rDtGJxu?=
 =?us-ascii?Q?80njctkn1mBEnRRp9/uV8Nh+AXMd96RlhxmnN1I31iOeoCQauGbeuJCeMRFU?=
 =?us-ascii?Q?wzMOXyOQlDFVW7Rie07yH4RQAMLwyqRHxmiIKtOO8IOaisqQOKmYj/uxgIIR?=
 =?us-ascii?Q?N9M6w2ewZ7lgiGq7AWpRvGGuclG6flb4KX7HVL8d+QcN/AaclbkcZG+5I2NT?=
 =?us-ascii?Q?8jzZFEo36xCd/vdmc1S+6nr6UaqTM47cD9erOs2P2cXTq7c58lTNsu+8Kmem?=
 =?us-ascii?Q?NY8ZaR8KqLrHr4e/HRKBg0+b/mDLEEBcubPp9j2ORoNwROhIuVJecg0rvpSL?=
 =?us-ascii?Q?Srt0MUAKDsAYIANcmRpK3LRbgvLGuVsxFJBOHRH7G8HHrPLO0cWFpjBnuwBX?=
 =?us-ascii?Q?kA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f302aa99-d204-4c2a-147d-08db164e4a90
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2023 10:02:51.6648
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FT8tzgU4DkDNw2iDfyZ7YkrzykoPEen6POUftWF9M8BnsP8e2NUXIH1OgxM+z59PKfhhd1dISnPON8isrGBBO237+LOiDrbpDPMRrzmyM64=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4556
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sakari,

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: 22 February 2023 05:03 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> Cc: Conor Dooley - M52691 <Conor.Dooley@microchip.com>;
> paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> linux-imx@nxp.com; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; jacopo.mondi@ideasonboard.com; Battu
> Prakash Reddy - I30399 <Prakash.Battu@microchip.com>
> Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth
> mode
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Wed, Feb 22, 2023 at 10:20:56AM +0000, Shravan.Chippa@microchip.com
> wrote:
> > Hi Sakari,
> >
> > > -----Original Message-----
> > > From: Sakari Ailus <sakari.ailus@iki.fi>
> > > Sent: 22 February 2023 03:36 PM
> > > To: Conor Dooley - M52691 <Conor.Dooley@microchip.com>
> > > Cc: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>;
> > > paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> > > mchehab@kernel.org; robh+dt@kernel.org;
> > > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> > > s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com;
> > > linux-imx@nxp.com; linux-media@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> > > kernel@lists.infradead.org; Jacopo Mondi
> > > <jacopo.mondi@ideasonboard.com>; Battu Prakash Reddy - I30399
> > > <Prakash.Battu@microchip.com>
> > > Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower
> > > bandwidth mode
> > >
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > know the content is safe
> > >
> > > On Wed, Feb 22, 2023 at 12:03:10PM +0200, Sakari Ailus wrote:
> > > > On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:
> > > > > On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:
> > > > > > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:
> > > > > > > From: Shravan Chippa <shravan.chippa@microchip.com>
> > > > >
> > > > > > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct
> > > v4l2_subdev *sd,
> > > > > > >         struct v4l2_subdev_format fmt =3D { 0 };
> > > > > > >
> > > > > > >         fmt.which =3D sd_state ? V4L2_SUBDEV_FORMAT_TRY :
> > > V4L2_SUBDEV_FORMAT_ACTIVE;
> > > > > > > -       imx334_fill_pad_format(imx334, &supported_mode, &fmt)=
;
> > > > > > > +       imx334_fill_pad_format(imx334, &supported_modes[0],
> > > > > > > + &fmt);
> > > > > >
> > > > > > Now that there are multiple modes supported, this would appear
> > > > > > to get the width, height as well as the other fields (apart
> > > > > > from mbus
> > > > > > code) from the first mode.
> > > > >
> > > > > Is this statement supposed to be a request to change something,
> > > > > or just a throwaway comment? It's a little hard for me to
> > > > > understand your intention here, sorry.
> > > >
> > > > Just pointing to what looks like a bug.
> > >
> > > Ah, my bad. Please ignore the comment.
> > >
> > > This is indeed about init_cfg(), not s_fmt().
> > >
> >
> > I will try to fix init_cfg()
>=20
> There's no problem with it. Please ignore my original comment on this.

Just checking, Do I need to do any modifications or the current code is fin=
e?

Thanks,
Shravan

>=20
> --
> Sakari Ailus