From:   Chancel Liu <chancel.liu@nxp.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: Re: [PATCH 2/4] ASoC: dt-bindings: wlf,wm8524: Add a property to
 specify power up sequency time
Thread-Topic: Re: [PATCH 2/4] ASoC: dt-bindings: wlf,wm8524: Add a property to
 specify power up sequency time
Thread-Index: AQHZSD6iKP3DVcsE70eUS5M7nhJXLA==
Date:   Fri, 24 Feb 2023 10:56:22 +0000
Message-ID: <VI1PR04MB4222996DB8494FD14A1D5FCEE3A89@VI1PR04MB4222.eurprd04.prod.outlook.com>
References: <20230222113945.3390672-1-chancel.liu@nxp.com>
 <20230222113945.3390672-2-chancel.liu@nxp.com>
 <Y/YPkgOreByREmOz@sirena.org.uk>
In-Reply-To: <Y/YPkgOreByREmOz@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gkU44iJrU/C62/PpZ1IkPjeGxK6t5qseA+bfUOUhGTqer0DVMS3Tsk5+G8W7?=
 =?us-ascii?Q?Nuw8VjQMbgws3jHJoKVVEqta4t6bni/ReoNdk8HFkocpMLOTyHmI8J6LWSJv?=
 =?us-ascii?Q?v02EuW8h6Yl6/Pv6dH2p/g4M/zUI2m3/r3wYP5zfECnfSOFVCeJOFSujCVnF?=
 =?us-ascii?Q?gi+ROj5uTPOSVizHJi2gDHrgLtg2hn7ollpIr+fx8eXd28IUO7iq0e36qwEM?=
 =?us-ascii?Q?fl6BNT48+IJrgH8H4RojyVbnNpd0qr5JP1wXqlCp9W/ercREL6LNXjokvvn6?=
 =?us-ascii?Q?6ShoiMC+SSYHX+jSV+vJ+iEI1X5Jj+lz33YaZ1Anb7dMOgXrSxAV/mMxovDP?=
 =?us-ascii?Q?1rSrKaURQU3RCBIDEvSFdj+b64ZDtpeHkLwvxFtxsIat+w6IunQhtRaoLbe+?=
 =?us-ascii?Q?ZZglqdZYgGswoHI00aFBBegnKp4xS833vIyPRShuhUWVebYEuuDfabunAM39?=
 =?us-ascii?Q?0AsofFqx1DYZS/pGdSbEeJdsapJASEguOEV5WaoH/yePn926zyvz00nj3VWq?=
 =?us-ascii?Q?pdZnVSh8P1ToPykR1WOvhESkt8A/7+c5LhRucsLIpCCuRJTMcJ/INyKvi+OD?=
 =?us-ascii?Q?6qBWKRIV74q1LkRCsQO/7OnCGaOnyNo7kz3/bdAQLPrQmasi7MsM2b3/CW8Z?=
 =?us-ascii?Q?l01PnJ8UnkK7BLOxZq33MIA3/yuGPj8b93nbVghMqqoJrPAB7nYq7jDyHyJH?=
 =?us-ascii?Q?ap3obSVGhTtztdlsB2t8mwraPpo5hqkYsme9fUl/Pq5mRijEhcdtz+15gvnO?=
 =?us-ascii?Q?aESPhgxN13P7lRyY3No+y/wx07eVz9nXYVdFmIou1p4fnBUJo+qL7lEmmYwT?=
 =?us-ascii?Q?+8rOvMtXLql4/2p8JtmBo/MehTMpb/ad91b07Xs1Wn8Wo4A9d9P9ktwXWv2X?=
 =?us-ascii?Q?aTubdaCAFd3RBTdAnGunntySYENJqzx4yjYAyc1sLKb8r684WHmzv5caYWH2?=
 =?us-ascii?Q?qCTn/gXMxNjUrri2wVPe1JdAkbVlZDZrM++4Yak8zoCUx9eRzi33baczcOTb?=
 =?us-ascii?Q?wdMKxpVdk+j7JGhhM8fWJRDPNGaDKlRlgyYB58e/2wI4q1KkRLyK1Zn11Z/M?=
 =?us-ascii?Q?qyXw9uAgGfyANTQOox9KNNAm3vYsaKDU+bAsKwCAA/V9MNcPSIR2a053xtY4?=
 =?us-ascii?Q?P4jbaWY745jvEVgtAO2yUUS3mT7ohNgMxSkDyxsPr1YHC24+bqpmdx/4kFly?=
 =?us-ascii?Q?cc6rK4ks2eZyprjYzFFAuxSiSmE/G8fEtGCyCf/eIP+/Ohgp4rrm/g+8iDdS?=
 =?us-ascii?Q?OKll+4zFTGvK/j6DZHn53+GkVB/OAvEXW3mxgKv5Ad3gzuyrDesDRq2KlGS8?=
 =?us-ascii?Q?rZJgFp0+OdQukcV9h8lwQ8ZxxOmPRNnWRyrM+COB+NoKG4Svj8/LNFGescik?=
 =?us-ascii?Q?0Q/8g7okMvki5NW3JfMOzSKuY4cfZ0Mrv9gjb7Vl7A6k9rclf5BLyhE2HISq?=
 =?us-ascii?Q?PxcbIrCbEh+sLRHzxcTvMvRwMNwMEkJsyAIfpzAyP6uMdfOnpED5/rllQPXV?=
 =?us-ascii?Q?8Rnrz9t4jRiEUOsqnc8D0QR++jotw62OpBmEogcz8AAAJUtXRLEz4AlUnt1N?=
 =?us-ascii?Q?00DakjLwJ85Lhl5lFK/K9oK+WOE6GS/k17OTKgka?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4222.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7fcf3ff-6fe2-4b59-a5c5-08db1655c48e
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2023 10:56:22.8146
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XNuG9SfGHaaOrVKGkkaCU+7QWHWKtBsw0/4Z4jDCpPhGxv8JIHevJPhIVUToZVeA8aw/70wudWL+Iwd+4m4vPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8567
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Feb 22, 2023 at 07:39:43PM +0800, Chancel Liu wrote:
> > This property specifies power up to audio out time. It's necessary
> > beacause this device has to wait some time before ready to output
> > audio after MCLK, BCLK and MUTE=3D1 are enabled. For more details about
> > the timing constraints, please refer to WTN0302 on
> > https://www.cirrus.com/products/wm8524/
>=20
> According to that the delay is a property of MCLK and the sample rate rat=
her
> than a per board constant, it shouldn't be in DT but rather the driver sh=
ould
> figure out the required delay on each startup.

I can't agree with you more. From the power up to audio out timing table in
WTN0302, the delay depends on sample rate and MCLK. Driver should calculate=
 it
rather than read it from DT. However as I mentioned in my last email, value=
s in
the table seem not accurate for all systems. It's a kind of compromise to g=
et
the value from DT. Do other codecs have a similar situation?

Thank you very much for your suggestions!

Regards,=20
Chancel Liu