Message-ID: <c4ee1a7b-a500-5fa5-6a97-93b1eba2c852@linaro.org>
Date:   Fri, 24 Feb 2023 12:00:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 2/4] ASoC: dt-bindings: wlf,wm8524: Add a property to
 specify power up sequency time
Content-Language: en-US
To:     Chancel Liu <chancel.liu@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20230222113945.3390672-1-chancel.liu@nxp.com>
 <20230222113945.3390672-2-chancel.liu@nxp.com>
 <506f92cd-7cf5-4fd5-a930-9af086732f84@linaro.org>
 <VI1PR04MB42221B1708BA02B1FA2149D9E3A89@VI1PR04MB4222.eurprd04.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <VI1PR04MB42221B1708BA02B1FA2149D9E3A89@VI1PR04MB4222.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/02/2023 11:54, Chancel Liu wrote:
>> On 22/02/2023 12:39, Chancel Liu wrote:
>>> This property specifies power up to audio out time. It's necessary
>>> beacause this device has to wait some time before ready to output audio
>>
>> typo... run spellcheck, also on the subject
>>
>>> after MCLK, BCLK and MUTE=1 are enabled. For more details about the
>>> timing constraints, please refer to WTN0302 on
>>>
>>>
>>> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
>>> ---
>>>  .../devicetree/bindings/sound/wlf,wm8524.yaml          | 10
>> ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8524.yaml
>> b/Documentation/devicetree/bindings/sound/wlf,wm8524.yaml
>>> index 09c54cc7de95..54b4da5470e4 100644
>>> --- a/Documentation/devicetree/bindings/sound/wlf,wm8524.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8524.yaml
>>> @@ -21,6 +21,15 @@ properties:
>>>      description:
>>>        a GPIO spec for the MUTE pin.
>>>
>>> +  wlf,power-up-delay-ms:
>>> +    maximum: 1500
>>
>> maximum is 1003. Where do you see 1500?
>>
>> minimum: 82
>>
> 
> Yes, you are absolutely right. From the power up to audio out timing table in
> WTN0302, the minimum number is 82 and the maximum is 1003.
> 
> Consider the following possibilities:
> 1. These timings may depend on the system design
> 2. These timings may be simulated results
> 3. These timings may be the minimum values
> 
> I set a larger value trying to extend the time. The larger value of course
> introduces unwanted time delay but it benefits on avoiding beginning audio
> lost.
> 
> I also did some tests on a board. If I want to work on 48KHZ sample rate and
> 512FS, the recommended value is 143. But the test result showed 143ms is not
> enough. I increased the value to 500ms and could hear the beginning sound.

Maybe you miss proper regulator ramp-up?

> 
> Maybe it's a better choice to let DT set the suitable value? Is there a similar
> situation before?

That's not really good argument. DT should describe hardware and if this
property does not match hardware, it means you mix this with something
else. Something not for DT.


Best regards,
Krzysztof