Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5B2C678DB for ; Fri, 24 Feb 2023 11:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbjBXLqI (ORCPT ); Fri, 24 Feb 2023 06:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjBXLqG (ORCPT ); Fri, 24 Feb 2023 06:46:06 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5388164D6E; Fri, 24 Feb 2023 03:46:04 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 80E8A1EC0723; Fri, 24 Feb 2023 12:46:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1677239162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=OSDHzpRiPKXFuKbj/ntPOkDODEh8hWASFyXRMMoKKPg=; b=aA+1bgzgnvaLFpgSuz1deBeWtCAEBmlV7GEzr7ZA4Mp69V9HXC6O2/Ul+Pfxkyh4rVX5fc n3kDrsTIKdr7MJGhF4cuP0UpC14Urlzpbs+vc6PJC4x5S5P+o+Bmw0KsEqIkEtE1ARcMxk ahkS3utYulVNwD95M9K9ipo0UizTrH4= Date: Fri, 24 Feb 2023 12:45:57 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v6 37/41] selftests/x86: Add shadow stack test Message-ID: References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-38-rick.p.edgecombe@intel.com> <5fe0874655a7190a6ea5a070584d2603522f4395.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5fe0874655a7190a6ea5a070584d2603522f4395.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2023 at 05:54:55PM +0000, Edgecombe, Rick P wrote: > The proposed Makefile solution seems a bit unusual. What about this > less complicated solution to just make this case work? I like simple. :) > So alternatively, why not just always encourage building the headers > before running the selftests by warning if > ${abs_srctree}/usr/include/linux is not found? s/encourage/automate/ Imagine this situation: maintainer says: "please run the selftests". User says, "uh oh, it fails building, I need to figure that out first." So we should not have users have to figure out stuff if we can code it to happen automatically for the default case. If they want something special, then they can do all the figuring out they want. :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette