Message-ID: <e9da7a1e-d48f-014b-a0a7-841c77feb12f@gmail.com>
Date:   Fri, 24 Feb 2023 21:28:47 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2
 appliance
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Cc:     andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net,
        soc@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
References: <20230223132502.2045-1-musashino.open@gmail.com>
 <20230223132502.2045-2-musashino.open@gmail.com>
 <76395d89-1c56-12b2-b6f7-e77603019b70@linaro.org>
Content-Language: en-US
From:   INAGAKI Hiroshi <musashino.open@gmail.com>
In-Reply-To: <76395d89-1c56-12b2-b6f7-e77603019b70@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

thank you for the comment.

On 2023/02/23 23:17, Krzysztof Kozlowski wrote:
> On 23/02/2023 14:25, INAGAKI Hiroshi wrote:
>> Add device tree for Internet Initiative Japan Inc. (IIJ) SA-W2 appliance.
>>
>> Specification:
>>
>> - SoC         : Marvell Armada 380 88F6810
>> - RAM         : DDR3 256 MiB
>> - Flash       : SPI-NOR 32 MiB
>> - WLAN        : 2x Mini PCI-E slots
>>    - 2.4 GHz   : Atheros AR9287
>>    - 5 GHz     : Qualcomm Atheros QCA9880
>> - Ethernet    : 5x 10/100/1000 Mbps
>>    - Switch    : Marvell 88E6172
>> - LEDs        : 12x
>> - Buttons     : 1x
>> - Serial      : "CONSOLE" port (RJ-45, RS-232C level)
>>    - port      : ttyS0
>>    - settings  : 115200 8n1
>>    - assignment: 1:NC , 2:NC , 3:TXD, 4:GND,
>>                  5:GND, 6:RXD, 7:NC , 8:NC
>> - USB         : 2x USB 2.0 Type-A
>>    - Hub       : SMCC USB2514B
>> - Power       : DC Input or PoE Input
>>    - DC        : 12 VDC, 3 A
>>    - PoE       : 802.3f
>>      - module  : Silvertel Ag9712-2BR
>> - Bootloader  : PMON2000 based
>> - Stock OS    : NetBSD based
>>
>> Image header for stock bootloader:
>>
>> 0x00 - 0x07: Identifier      , ascii, "SEIL2015"
>> 0x08 - 0x57: Copyright       , ascii
>> 0x58 - 0x5b: Checksum (CRC32), hex
>> 0x5c - 0x5f: Version Format  , hex  , 0x00000001
>> 0x60 - 0x63: Major Version   , hex
>> 0x64 - 0x67: Minor Version   , hex
>> 0x68 - 0x87: Release Version , ascii
>> 0x88 - 0x8b: Xor Key?        , hex  , 0x00000000 (if not encoded)
>> 0x8c - 0x8f: Data Length     , hex
>>
>>    example:
>>
>>    Identifier     : "SEIL2015"
>>    Copyright      : "ARM OpenWrt Linux-5.15.94"
>>    Checksum       : 0xd575759f (calculated from kernel data)
>>    Version Format : 0x00000001
>>    Major Version  : 0x00000009
>>    Minor Version  : 0x00000063
>>    Release Version: "r22151-318ed84c8d"
>>    Xor Key?       : 0x00000000
>>    Data Length    : 0x35312d33 (length of kernel data)
>>
>> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
>> ---
>>   arch/arm/boot/dts/Makefile                 |   1 +
>>   arch/arm/boot/dts/armada-380-iij-sa-w2.dts | 391 +++++++++++++++++++++
>>   2 files changed, 392 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/armada-380-iij-sa-w2.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index efe4152e5846..19119a3f4f1e 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1523,6 +1523,7 @@ dtb-$(CONFIG_MACH_ARMADA_370) += \
>>   dtb-$(CONFIG_MACH_ARMADA_375) += \
>>   	armada-375-db.dtb
>>   dtb-$(CONFIG_MACH_ARMADA_38X) += \
>> +	armada-380-iij-sa-w2.dtb \
>>   	armada-381-netgear-gs110emx.dtb \
>>   	armada-382-rd-ac3x-48g4x2xl.dtb \
>>   	armada-385-atl-x530.dtb\
>> diff --git a/arch/arm/boot/dts/armada-380-iij-sa-w2.dts b/arch/arm/boot/dts/armada-380-iij-sa-w2.dts
>> new file mode 100644
>> index 000000000000..beeecbb0f5f8
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/armada-380-iij-sa-w2.dts
>> @@ -0,0 +1,391 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>> +/*
>> + * Device Tree file for Internet Initiative Japan Inc. SA-W2 Appliance
>> + *
>> + * Copyright (c) 2023, INAGAKI Hiroshi <musashino.open@gmail.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include "armada-380.dtsi"
>> +
>> +/ {
>> +	model = "IIJ SA-W2";
>> +	compatible = "iij,sa-w2", "marvell,armada380";
> It would be nice to start documenting the board compatibles, at least
> for new boards.

So...how do I do that?

>
> Best regards,
> Krzysztof
>

Regards,
Hiroshi