Date:   Fri, 24 Feb 2023 12:30:43 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Chancel Liu <chancel.liu@nxp.com>
Cc:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: Re: [PATCH 4/4] ASoC: wm8524: Delay some time to follow power up
 sequency
Message-ID: <Y/it8z/w2c+gS/85@sirena.org.uk>
References: <20230222113945.3390672-1-chancel.liu@nxp.com>
 <20230222113945.3390672-4-chancel.liu@nxp.com>
 <Y/YPNMGMZcVZs3xy@sirena.org.uk>
 <VI1PR04MB42220617033D1DE404AF445DE3A89@VI1PR04MB4222.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h1Fxj73TV969Kz5/"
Content-Disposition: inline
In-Reply-To: <VI1PR04MB42220617033D1DE404AF445DE3A89@VI1PR04MB4222.eurprd04.prod.outlook.com>
Precedence: bulk


--h1Fxj73TV969Kz5/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 24, 2023 at 10:54:59AM +0000, Chancel Liu wrote:
> > On Wed, Feb 22, 2023 at 07:39:45PM +0800, Chancel Liu wrote:

> > Doing a 100ms busy wait in atomic context does not seem like a great
> > idea, never mind a 1.5s one.  This shouldn't be done in trigger, it
> > needs to be done later - digital_mute() might be a better time to hook
> > in, though longer delays like this are really quite bad.

> Yes, such long time delay in driver is very bad. But this device requires
> waiting some time before able to output audio. We have to wait otherwise the
> beginning data may be lost.

It's not just that it's doing this in the driver, it's doing it in the
trigger() function which runs in atomic context.  That's unreasonable.

> The power up to audio out timing occurs after MCLK, BCLK and MUTE=1 are ready.
> I added the delay in trigger() because some CPU DAI drivers enable BCLK in
> trigger(). You suggested moving the delay to digital_mute(). It seems
> digital_mute() is called before cpu_dai->trigger. Please correct me if I'm
> wrong.

Hrm, right - in any case, it needs to be somewhere that isn't atomic
context.

--h1Fxj73TV969Kz5/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP4rfIACgkQJNaLcl1U
h9A1lwf+OS+A++3bwTMcv2PfQianyzMlPcFLYR42hoFkNYSf1dY/omT9tJyVpD1x
ioWTgVrm4rhgyUmsGODd3WFJ4WeUq4E3mrKpy2xpSvH6u2z3J50F8WNuHVYxq1HN
6bH/LMog2u2HINCyatYyEz7XID0YPqfzlNiRBfG8zZ3DCLFhPRpFQySy8EC5ShNK
ih+rrKeJbC/ZO4Ob+Ziw50d0ifrqQxSq8vlcnqPryImayJj1jYoQLYuUv1D1TBQx
BONmKLNc6OELYJois8Jlni3ld43Tanxvb0RmebhQjYlPqHx03PwjXQ1N0J1UWDRD
0aNN+NG0jyxp5D895Nax9Hz6F6fw4w==
=MHUI
-----END PGP SIGNATURE-----

--h1Fxj73TV969Kz5/--