MIME-Version: 1.0
References: <20230224092044.3332374-1-void0red@gmail.com> <CAD-N9QX5i5toj8cs7DxBjYWtRGf3ZRnfTAf809sFW6iX0Ktfmw@mail.gmail.com>
In-Reply-To: <CAD-N9QX5i5toj8cs7DxBjYWtRGf3ZRnfTAf809sFW6iX0Ktfmw@mail.gmail.com>
From:   Kang Chen <void0red@gmail.com>
Date:   Fri, 24 Feb 2023 20:43:22 +0800
Message-ID: <CANE+tVq0fwuuyMmrs4yyC21s_P8w0+WUS9zYZDxwda=++YpwqA@mail.gmail.com>
Subject: Re: [PATCH] usb: gadget: udc: add return value check of kzalloc in mv_udc_probe
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Dongliang,

I totally agree with you. I checked the other drivers using
status_req->req.buf structure, they free the memory when
the driver removed. But in this driver, I can't find such code. So,
as you said, it needs a devm_kazlloc instead of a kzalloc to manage
the memory and avoid a memory leak.

Thanks for your correction. I will post a new patch later.

Dongliang Mu <mudongliangabcd@gmail.com> =E4=BA=8E2023=E5=B9=B42=E6=9C=8824=
=E6=97=A5=E5=91=A8=E4=BA=94 19:06=E5=86=99=E9=81=93=EF=BC=9A

>
> On Fri, Feb 24, 2023 at 5:28 PM void0red <void0red@gmail.com> wrote:
> >
> > From: Kang Chen <void0red@gmail.com>
> >
> > Even an 8-byte kzalloc will fail when we don't have enough memory,
> > so we need a nullptr check and do the cleanup when it fails.
> >
> > Reported-by: eriri <1527030098@qq.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D217081
> >
> > Signed-off-by: Kang Chen <void0red@gmail.com>
> > ---
> >  drivers/usb/gadget/udc/mv_udc_core.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/=
udc/mv_udc_core.c
> > index b397f3a84..6dd6d52de 100644
> > --- a/drivers/usb/gadget/udc/mv_udc_core.c
> > +++ b/drivers/usb/gadget/udc/mv_udc_core.c
> > @@ -2230,6 +2230,10 @@ static int mv_udc_probe(struct platform_device *=
pdev)
> >
> >         /* allocate a small amount of memory to get valid address */
> >         udc->status_req->req.buf =3D kzalloc(8, GFP_KERNEL);
>
> Hi Kang and gregkh,
>
> I think there is a memory leak in this kzalloc. It seems there is no
> deallocation for this allocated object.
>
> As the surrounding allocation statements suggest,
> we should turn kzalloc to devm_kzalloc.
>
> > +       if (!udc->status_req->req.buf) {
> > +               retval =3D -ENOMEM;
> > +               goto err_destroy_dma;
> > +       }
> >         udc->status_req->req.dma =3D DMA_ADDR_INVALID;
> >
> >         udc->resume_state =3D USB_STATE_NOTATTACHED;
> > --
> > 2.34.1
> >