Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762984AbXIKIlf (ORCPT ); Tue, 11 Sep 2007 04:41:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761413AbXIKIl0 (ORCPT ); Tue, 11 Sep 2007 04:41:26 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:3238 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759348AbXIKIlZ (ORCPT ); Tue, 11 Sep 2007 04:41:25 -0400 Date: Tue, 11 Sep 2007 16:40:58 +0800 From: Herbert Xu To: Ingo Oeser Cc: Bob Gilligan , linux-kernel@vger.kernel.org, Linux Crypto Mailing List Subject: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page Message-ID: <20070911084058.GA4469@gondor.apana.org.au> References: <5562608.649291189210157514.JavaMail.root@tahiti.vyatta.com> <20070908041423.GA8961@gondor.apana.org.au> <20070910075829.GA25851@gondor.apana.org.au> <200709102146.47655.ioe-lkml@rameria.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709102146.47655.ioe-lkml@rameria.de> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 23 On Mon, Sep 10, 2007 at 09:46:46PM +0200, Ingo Oeser wrote: > > What about using max() for this to make your intention obvious? > > static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len) > { > u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); > return max(start, end_page); > } Yes that looks sane. Could you please send a patch? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/