From:   Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To:     lina@asahilina.net
Cc:     alex.gaynor@gmail.com, asahi@lists.linux.dev,
        bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
        linux-kernel@vger.kernel.org, ojeda@kernel.org,
        rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH 2/2] rust: sync: arc: Add UniqueArc<MaybeUninit<T>::assume_init()
Date:   Fri, 24 Feb 2023 11:37:01 -0300
Message-Id: <20230224143701.755103-1-yakoyoku@gmail.com>
In-Reply-To: <20230224-rust-arc-v1-2-568eea613a41@asahilina.net>
References: <20230224-rust-arc-v1-2-568eea613a41@asahilina.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Feb 24, 2023 at 04:59:34PM +0900, Asahi Lina wrote:=0D
> We can already create `UniqueArc<MaybeUninit<T>>` instances with=0D
> `UniqueArc::try_new_uninit()` and write to them with `write()`. Add=0D
> the missing unsafe `assume_init()` function to promote it to=0D
> `UniqueArc<T>`, so users can do piece-wise initialization of the=0D
> contents instead of doing it all at once as long as they keep the=0D
> invariants (the same requirements as `MaybeUninit::assume_init()`).=0D
> =0D
> This mirrors the std `Arc::assume_init()` function. In the kernel,=0D
> since we have `UniqueArc`, arguably this only belongs there since most=0D
> use cases will initialize it immediately after creating it, before=0D
> demoting it to `Arc` to share it.=0D
=0D
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>=0D