Message-ID: <47a67799-27d9-094e-11c3-a18efcf281e2@intel.com>
Date:   Fri, 24 Feb 2023 17:07:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping
 for ethtool statistics
Content-Language: en-US
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
 <20230217110211.433505-4-rakesh.sankaranarayanan@microchip.com>
 <84835bee-a074-eb46-f1e4-03e53cd7f9ec@intel.com>
 <20230217164227.mw2cyp22bsnvuh6t@skbuf>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230217164227.mw2cyp22bsnvuh6t@skbuf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXRtTGEwbEFkOU5UeDlnT04rdGo2aXBxcTJ6T05sbmJNOWJzWFNIM1gyeFUv?=
 =?utf-8?B?SXpaWjlyaG1yZ2JpYWNDSGlESjJ0cStPdHNIVVlQYWQ3YVZnTk9RZHFEU0U4?=
 =?utf-8?B?bDZzTldnbnIzQm54QjcxRGw0RXBVU2psZ3pyQjJIRTRLQk1MUkt3b0hYc2lw?=
 =?utf-8?B?M3YvZTV2ZUEwRWQ4MWNwZWhnWUZ4Y2ViQ0tWN3dFMXhNdHd2SGgyMFF3NmJr?=
 =?utf-8?B?WUthQTlMTEJibEZvUENhOW9DUlJ1OVp5YndZbEFLUVFSYXJSSEV6OVY5Wmxk?=
 =?utf-8?B?QWFLb0dlcFJCeXdtQTd2U0dCK2RnRVBqbGpuZzQwZmpJVmhvU0F6dnYzbC9E?=
 =?utf-8?B?cGtIU3ZNOFJrS1FNZU03S3YyZFpGU010RUhFbWswZGZheUhHRnh4L0NqMTgz?=
 =?utf-8?B?WFdLbkJhc0RuRytXZ21XNEJsMkZKaEt0djVaSUtkeE9XWWdqRngrRzRkOExV?=
 =?utf-8?B?Nm9XdTYvL2lZZitkcmZhMEQ3UlZKazkxVTdOQUV5M1RZUkxyOGpEZUprcURq?=
 =?utf-8?B?UTU0eEZlWE1pYmtLSk5rL1pVNCtIbzNQNlF6a09mdkZ6UlVKdGc0b0hQL1FF?=
 =?utf-8?B?cm9WQjFzMXhycmdiNDBsSFh3RkhrUnJnZ1plWU11TTNvdkhhNExRcWI5cEFR?=
 =?utf-8?B?SklqVzdpQW5mc3ZrRE9hWXpYMERsVGNHZXN2em9CMUpJcStrTG5jSnE1YVBV?=
 =?utf-8?B?VzVqeEl5cHdhcU82RGpuKzZ0NEJoSzArQVRReTNEdHQvdTR5WlptOWFWcHpL?=
 =?utf-8?B?cktKaGsxRWcyQWxTVXZGcEV1Unp2OS9HQmxnOG5WbEI5N0JJVlIyOEt0Y3BF?=
 =?utf-8?B?U0thM1V4S2s3dksySm01RzRTeWQ2U2hrcy9yY0pzNTlhMWIvTW5WbSszQXlj?=
 =?utf-8?B?bUo5ekh2OFNJWkJzenRzcjJxZFlPYlNBVFlmWVNFZ0RpRkZVcy9DRS93N1Ir?=
 =?utf-8?B?Um44MXBjV2xPM1pBbzdWZlBCb2poWWJzTUlSQk5RbUljT3lqcGlORUIrVzM0?=
 =?utf-8?B?cU1RclJ2STdRNnBSOTJGSDgvenVtaFRHNTBLSXdvak9DK1BoQ2Fyd2VmTmFy?=
 =?utf-8?B?SWY4MER6UlFIZkhzSWU2UlBMODlvOW9TWm9OOTEwcEZLOUFJenovdG9nZUhZ?=
 =?utf-8?B?djlJN011dU9Rc21hdVJyMSs0ZTRvb2tuVkVtOUQydlJLUVRkNlA3SGZDRWU3?=
 =?utf-8?B?S3V6N0lQS1kyRzVTNzdQdGdJVkdpMTEwb2dBKzhuSzdLK2drQzBTbzlIL1po?=
 =?utf-8?B?d292Z2Zjc2oxQUJYdUZ5Z1ZQL0owUU9XOGR2MkFFRnkxSlhDMStza3hiVXpQ?=
 =?utf-8?B?cDN3NWN6NmU1YUNrK3FVdGFTd1BITmw0SW5ORXhiY21VVnZ5OHJuY3QrYzZy?=
 =?utf-8?B?RkdyQXJWbGNPdU9xb1BqM1V5RGM1N21mMmRRajJkVmdQL1ErRUJZQzJqNkdL?=
 =?utf-8?B?c1B2VC9pbzZTZkJ2cFN1QmlhT05FWEYzY0pnQ1MwUGQzSmd0cTExdjBuMlBj?=
 =?utf-8?B?eXRjNUxZQ3JhbVM3WWFIMVBHM0R1VXA4M0EzMXBmLzRISWsybFRjT3dZTUMz?=
 =?utf-8?B?WVl1VnhuS2xHbHRRamptWGJFNjdvdC9LK2l3REVtWFFRZCsydkZveEhNZmhV?=
 =?utf-8?B?THBDL3F3KzZNeHhOZ2JjTDNjRXFvcG0za20zYUIvSndBTGVFKytQQjNEcmtG?=
 =?utf-8?B?dW1VTlpwbU1XUlRSS2Q5VE1BUFVLWUdDdG5lemRucEdFL0FOeHd0NWtxV2Rq?=
 =?utf-8?B?SjhDU1VSUm12Y3NMZld1cmhWQlJtYjc3NW5WWWc0OFZKM3QzQnI4VnArTlZI?=
 =?utf-8?B?clR5dkhib3kyTUhJemZ2d0lCZTByRkhPWkdoM2FCSCtxbnNQdVdiTjg1Yk9D?=
 =?utf-8?B?cU1GYUVXZnFTRFlKSzVlVndCNGJYaTd4eCs5d1hWUjROaXYxME90dTdGd2Nh?=
 =?utf-8?B?L1FrSnZTV0hVRWlVTHNlSXloc3ZIamQ1dmMyZEhSb1BWeW5lNlhjVDdpc0Jl?=
 =?utf-8?B?OVdpeGlVRTBNWFpjRUtOSHgrV2xLYUxPSUdKKytSY1lMNVdwalJ6UkEyMXNj?=
 =?utf-8?B?UFBHcFRzTThnU0lFd2lCUDN3TStjR3ovY1dPN3pzK2V2emhKK1EyRVhrbS9V?=
 =?utf-8?B?VndZKzl2NlpyME1LQzJFdzBlMFpNcWlDYWFEMDc0SGhoa243ZTdnYTVXVjcr?=
 =?utf-8?Q?JYKcFB4pV6Q0T9fX66VGrXE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 17597150-c72c-414d-1ff7-08db16814db3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:08:01.6046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Rh4q7DWXqs9Q2ROHq+QaYC4/T+KtjeD3M3MMRfQfKhd0oKuzSmNzBiGgCUogDds2+4RdOLVyC2Y03F+d1iiPzLqOgFTe5pEM8AIpHaaez4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8190
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Vladimir Oltean <olteanv@gmail.com>
Date: Fri, 17 Feb 2023 18:42:27 +0200

> On Fri, Feb 17, 2023 at 04:01:15PM +0100, Alexander Lobakin wrote:
>>> +		++mib->cnt_ptr;
>>
>> Reason for the pre-increment? :)
> 
> because it's kool

:D The most common reason for it usually ._.

> 
> Somebody not that long ago suggested that pre-increment is "less resource consuming":
> https://patchwork.kernel.org/project/netdevbpf/patch/677a5e37aab97a4f992d35c41329733c5f3082fb.1675407169.git.daniel@makrotopia.org/#25197216
> 
> Of course, when pressed to explain more, he stopped responding.

Haha, classics.
It's not so common for people to show up back in the thread after you
ask them to show godbolt / asm code comparison.

Olek