Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8643AC7EE23 for ; Fri, 24 Feb 2023 16:40:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjBXQkA (ORCPT ); Fri, 24 Feb 2023 11:40:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjBXQj6 (ORCPT ); Fri, 24 Feb 2023 11:39:58 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8831D4C6CE; Fri, 24 Feb 2023 08:39:56 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10631"; a="317277623" X-IronPort-AV: E=Sophos;i="5.97,325,1669104000"; d="scan'208";a="317277623" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2023 08:39:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10631"; a="650405362" X-IronPort-AV: E=Sophos;i="5.97,325,1669104000"; d="scan'208";a="650405362" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 24 Feb 2023 08:39:45 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pVb6m-00BXFx-0G; Fri, 24 Feb 2023 18:39:44 +0200 Date: Fri, 24 Feb 2023 18:39:43 +0200 From: Andy Shevchenko To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Lee Jones Subject: Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE_LICENSE in non-modules Message-ID: References: <20230224150811.80316-1-nick.alcock@oracle.com> <20230224150811.80316-5-nick.alcock@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230224150811.80316-5-nick.alcock@oracle.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Andy Shevchenko > Cc: Lee Jones Please, use --cc parameter instead of polluting commit message. With this addressed, Reviewed-by: Andy Shevchenko > diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c > index b1548a933dc3..b745ace46e5b 100644 > --- a/drivers/mfd/intel_soc_pmic_crc.c > +++ b/drivers/mfd/intel_soc_pmic_crc.c > @@ -271,6 +271,5 @@ static struct i2c_driver crystal_cove_i2c_driver = { > module_i2c_driver(crystal_cove_i2c_driver); > > MODULE_DESCRIPTION("I2C driver for Intel SoC PMIC"); > -MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Yang, Bin "); > MODULE_AUTHOR("Zhu, Lejun "); -- With Best Regards, Andy Shevchenko