Date:   Fri, 24 Feb 2023 16:47:05 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
        jonathanh@nvidia.com, skomatineni@nvidia.com, ldewangan@nvidia.com
Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Message-ID: <Y/jqCRAenwbqc1Uu@sirena.org.uk>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kU7eO+WfDSUysTOv"
Content-Disposition: inline
In-Reply-To: <20230224163513.27290-1-kyarlagadda@nvidia.com>
Precedence: bulk


--kU7eO+WfDSUysTOv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 24, 2023 at 10:05:13PM +0530, Krishna Yarlagadda wrote:

>  		msg->actual_length += xfer->len;
> +		if (!xfer->cs_change && transfer_phase == DATA_TRANSFER) {
> +			tegra_qspi_transfer_end(spi);
> +			spi_transfer_delay_exec(xfer);
> +		}
>  		transfer_phase++;
>  	}
> -	if (!xfer->cs_change) {
> -		tegra_qspi_transfer_end(spi);
> -		spi_transfer_delay_exec(xfer);
> -	}

This looks like it'll do the wrong thing and do a change on every
transfer if cs_change isn't set?

--kU7eO+WfDSUysTOv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP46ggACgkQJNaLcl1U
h9D5sAf/ZFxIFrE6cDc+2bBL87DGFVmf4tz5wBnVZ5Ii3/J8onmDc8f7r+sUiEIk
+6B+kCZi0LECvQF229p03DvHT+Rgkq831RHFDCk2rBf89+JliLbk/mSqBUvZbNPL
1m2wtT/eY4OX0AUnVskE9zt3axB/q3QcZVHiWPmbIpYG0dJDnrdc94EuMhcojOAw
RWAE9HOtDc4X2yZjIdpp62awChHF7YNiZhxhRNFtZJGpQHTMvJA74mhrzIw/LwJC
etzUBaeUzN8ewSCaWMSuo3Bg3sojy2LfccQ5Wp5/dU9wn1mBTfEdKy25RQbxd0ZG
sFFc4V+T5pBEPX9NxPcZMBJXjyyO6w==
=TkdM
-----END PGP SIGNATURE-----

--kU7eO+WfDSUysTOv--