From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>
Subject: RE: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Topic: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Index: AQHZSG4K8+wSVKmZRkimkrAiwHDmq67eTmSAgAAAM/A=
Date:   Fri, 24 Feb 2023 16:50:00 +0000
Message-ID: <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
 <Y/jqCRAenwbqc1Uu@sirena.org.uk>
In-Reply-To: <Y/jqCRAenwbqc1Uu@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YsY+5uB9uwqg21Oo0OJhVlOloOYzMRgU/fZ0wRqUEgJ75cI7BPdSkG6NbiRQ?=
 =?us-ascii?Q?iSJMvEFD2G1ITAtyWriyYjvsQV6jaIvw3rJrPkIlrAGGguEmnf56Z6R0q6uH?=
 =?us-ascii?Q?mIyOqagh4QJxGMmRFnCDSg6OOtQVrn+QPhjsqJ7c3vryr4NUQFmMrHQMxfex?=
 =?us-ascii?Q?rrhitSTCDbEvK/dxppGK8AfTRkH7NC7n8yZYKgu/71bWPDLYRtjylyv5Y4ce?=
 =?us-ascii?Q?OfO5BFYAw9v9jkbrVWpX9S/oJxpw8Dl17pJQpiDmYpJ7kDYTQ6SnUtIbHsWX?=
 =?us-ascii?Q?QuJlW19GsdmB2N2o5PpwQmBG9ml8/TmMsXiIqAGnOIiiPTh+gHhpZZxOK2dc?=
 =?us-ascii?Q?6rpiQ0GbkJH1y5rSXsGxqwt+irkjjk9rboVdU9GAEc0wHaX8kiCl2Lbcohh4?=
 =?us-ascii?Q?qfPTR/in9TiWJoXskoS2v4altT1N85TVpibnlT70f0Oh2cRWxjfY4/lFFPKK?=
 =?us-ascii?Q?mesXAYid3MNiWtMMc/ftkmUVvb6W88AR5SmqLg2grV+xgieclFT1HX7n/W/S?=
 =?us-ascii?Q?NFklL7oiTk2P0+gOAgCyRgMDaG1n9YRMpm/z9WTArD+RJhnyNizoZEYF68K9?=
 =?us-ascii?Q?gddSIEA/KSsHL4HwAHRT9M/HPaY17F8frTOMNkqwtUDI8sN/GV8T6eTYNZ6B?=
 =?us-ascii?Q?4X2qCHtBYOVpsCK5F3UIzicmTEV/5W0Q2T7hN0qcdYfokexm7WR2p7WaoWgs?=
 =?us-ascii?Q?8GsT6utVN/z0mqJw59obwxPRNY5toa8lRN3S6cnwTbUMhtFm3mqK/SvlkEjq?=
 =?us-ascii?Q?422rO4NPNn3HevpUp4tdxeejftW2X8RA7Yo023NPBzT2s5QdoG327QTw7gu+?=
 =?us-ascii?Q?RYEacFYIw647MJTCePKK7sLrqjBibbDFwmivlMSsVuaIoxcz+ipRz4w49vM1?=
 =?us-ascii?Q?GAUyJgSti6+mWrwdf5U6VaxMCaDQy+EqS9VibZQkZl48Taknnl6MPYVDyXc3?=
 =?us-ascii?Q?cap35eUYpZCuMF3g+1yQHXASzCqJ9Jo+vvf/4Xuq9AVcHrlCy2WdyPOUSrVb?=
 =?us-ascii?Q?kPnPB6UBGyI25h3OBRwwte+iwjoAmRTK27Wp0x7LrelxCktIf/rwuv4BPhwE?=
 =?us-ascii?Q?BtjRShasij9bHzCELEE6dWO18ECR5g3cFQcxJminiJJwgZ0SQl0Bt1n2EMpO?=
 =?us-ascii?Q?9QT++sn0CtX2x5Um0StmIqz3IzZWghe+AEal22IY2hoHHes8m+GKrvJ1ZL0w?=
 =?us-ascii?Q?UqwywI7sr3/xjZJjV4g0hPpteNim8KoctaMP65uAPFPUD+I5pm73eQMygbWN?=
 =?us-ascii?Q?EVxw48mOCkH0zxz7noeDT1RTdbMozxeMNQH38ALkqG1sfZRBYj/sJPnxk4s1?=
 =?us-ascii?Q?Mv0uFzy/4kGLdDR8DKiy3FBqgUTCJXUe/OxZiC051pGcDAJzG59Z+dYy66Xk?=
 =?us-ascii?Q?6+ibRkKQifHGnIeEHFAryn4AHdcQLhtQPAvJwAUqIJHxSa3zwtQ3Vsr1HEwD?=
 =?us-ascii?Q?QIdeDASp26cECDbPf/jtRFiqXNWDESeZryJogDFeiVR9NEDNUBVaYZ+zFRpl?=
 =?us-ascii?Q?FkbtclEkuj7BLnKyAXao1CMa56hnobqVvwrmmxfdj4n/xAJSXgS13gOPUZLm?=
 =?us-ascii?Q?OJp6XXfrJ940B6VZNc4plTZOhtCKyZtC3nWXf3L1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32652841-4d08-4f1a-4dcb-08db16872b2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2023 16:50:00.3348
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o1xm2FXaenA+qyfsnIDWuOsTP9B5ZVBVQUmenRCIwiQ5bL6Fy+OWdTmSMbbjIrseHZ6lRgkvqpskQX47OBDnFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5830
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 24 February 2023 22:17
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: linux-spi@vger.kernel.org; linux-tegra@vger.kernel.org; linux-
> kernel@vger.kernel.org; thierry.reding@gmail.com; Jonathan Hunter
> <jonathanh@nvidia.com>; Sowjanya Komatineni
> <skomatineni@nvidia.com>; Laxman Dewangan <ldewangan@nvidia.com>
> Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
>=20
> On Fri, Feb 24, 2023 at 10:05:13PM +0530, Krishna Yarlagadda wrote:
>=20
> >  		msg->actual_length +=3D xfer->len;
> > +		if (!xfer->cs_change && transfer_phase =3D=3D DATA_TRANSFER)
> {
> > +			tegra_qspi_transfer_end(spi);
> > +			spi_transfer_delay_exec(xfer);
> > +		}
> >  		transfer_phase++;
> >  	}
> > -	if (!xfer->cs_change) {
> > -		tegra_qspi_transfer_end(spi);
> > -		spi_transfer_delay_exec(xfer);
> > -	}
>=20
> This looks like it'll do the wrong thing and do a change on every
> transfer if cs_change isn't set?
This condition is hit only in data phase which is end of message.
KY