Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 589D2C6FA8E for ; Fri, 24 Feb 2023 17:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbjBXRUK (ORCPT ); Fri, 24 Feb 2023 12:20:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjBXRUI (ORCPT ); Fri, 24 Feb 2023 12:20:08 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C4FE43468; Fri, 24 Feb 2023 09:20:07 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id g6so2364503iov.13; Fri, 24 Feb 2023 09:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=6nruIHAhdhx1kLlG3LLxcyHw+CS76kCYQby15s3Fp+Y=; b=IpamoNkd4cXS1VDYI2n56rf2X4LcZBHRzlXw71mavaB4o/VFmHAPvqlcZBuuuyV2T1 05SYpOUK/2Krm7rHdTiL9hszzpkwhMaHwREFeoCxZDiu/7vSq9glnbo1J6CDZ2V75RXK t1J43Ybp020bq2DdNo+xb3PUyGlYbzpQPXPBFIg41mclgJSXAz0F1EuKNkh8vMfaRFDc nR4WtHnvEgd81QKrw8ZajY8oeBY4YtONuZz9GL767Kba+KyBik0g4KcrIAVC944Efz6s EWhMHWpF1Er7YuhqmHlWCQbU/TiX+5DkGKVhvE8EaW8q7eu65HkAJ3/b7v3Bo/A/E8kV dBhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6nruIHAhdhx1kLlG3LLxcyHw+CS76kCYQby15s3Fp+Y=; b=pBgCsxhrqLPV6YlMRhSzpRD3jZkaSoz+MPCf2GF798YN06RnW9g8wHGd1knuWPRC5h uQk4WG+16d1jwCpiyU9UuBMoB4e+OlT1IL9jRZ45Sgw6zGFHFzrjfFQkbZSlbtUZPmf0 UUmYPxfaMJPK7yPUz/ni3LrscnPuJFsIMe7cwNoodYHQOv2ZTYGpO3rImJX+t5pS/bxI q6xvFNwLMtcDtYoAh2y81Gxv2756JTEj6sI5Z5QWldekAmrEKU2bUphrpkiEbpQskNjo tJ9v2xAeX80YKXMMyM8wtLDQoPCFTxEa4XjCIXAyzANqxRcUWYj5s0KzgVmyYLcYDx8N hk+Q== X-Gm-Message-State: AO0yUKW+R8qkzSDbYuDN9wc+RYRY9/AyQ6fBRfVjga8qXtOc+Cx+Qm+x MFAoOyF82o/xF5Wimr+9P2Q= X-Google-Smtp-Source: AK7set8NgV86UQeUeidAd60E4SLLlduW3eN2qKkqFJEQ/Lse8jHWimLTTUAnNOU966VV+v7wxtMv2A== X-Received: by 2002:a5d:8e01:0:b0:74c:822c:a6ac with SMTP id e1-20020a5d8e01000000b0074c822ca6acmr9886755iod.15.1677259206469; Fri, 24 Feb 2023 09:20:06 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n9-20020a5e8c09000000b00740710c0a65sm3552788ioj.47.2023.02.24.09.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 09:20:05 -0800 (PST) Sender: Guenter Roeck Date: Fri, 24 Feb 2023 09:20:04 -0800 From: Guenter Roeck To: Oleksij Rempel Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev Subject: Re: [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() Message-ID: <20230224172004.GA1224760@roeck-us.net> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-7-o.rempel@pengutronix.de> <20230224035553.GA1089605@roeck-us.net> <20230224041604.GA1353778@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230224041604.GA1353778@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Copying regzbot. #regzbot ^introduced 9b01c885be36 #regzbot title Network interface initialization failures on xtensa, arm:cubieboard #regzbot ignore-activity On Thu, Feb 23, 2023 at 08:16:06PM -0800, Guenter Roeck wrote: > On Thu, Feb 23, 2023 at 07:55:55PM -0800, Guenter Roeck wrote: > > On Sat, Feb 11, 2023 at 08:41:10AM +0100, Oleksij Rempel wrote: > > > Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). > > > > > > It should work as before except write operation to the EEE adv registers > > > will be done only if some EEE abilities was detected. > > > > > > If some driver will have a regression, related driver should provide own > > > .get_features callback. See micrel.c:ksz9477_get_features() as example. > > > > > > Signed-off-by: Oleksij Rempel > > > Reviewed-by: Andrew Lunn > > > > This patch causes network interface failures with all my xtensa qemu > > emulations. Reverting it fixes the problem. Bisect log is attached > > for reference. > > > > Also affected are arm:cubieboard emulations, with same symptom. > arm:bletchley-bmc emulations crash. In both cases, reverting this patch > fixes the problem. > > Guenter