Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763469AbXIKKLe (ORCPT ); Tue, 11 Sep 2007 06:11:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965829AbXIKKLE (ORCPT ); Tue, 11 Sep 2007 06:11:04 -0400 Received: from de01egw01.freescale.net ([192.88.165.102]:46986 "EHLO de01egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965688AbXIKKLB convert rfc822-to-8bit (ORCPT ); Tue, 11 Sep 2007 06:11:01 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors. Date: Tue, 11 Sep 2007 18:10:53 +0800 Message-ID: <46B96294322F7D458F9648B60E15112C85D61E@zch01exm26.fsl.freescale.net> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors. Thread-Index: AcfxPC/wGi09hKt4R6O5xlS4AldUsgAJWZkgAL6GIGA= References: <11891624582950-git-send-email-wei.zhang@freescale.com> From: "Zhang Wei-r63237" To: "Nelson, Shannon" , Cc: , , , "Zhu Ebony-r57400" , Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 29 > > If this is experimental, perhaps you should mark the depends line as > such > depends on on DMA_ENGINE && PPC && EXPERIMENTAL I'll add EXPERIMENTAL for MPC83xx only. > > [...] > > >+ > >+ fsl_dma_memcpy_issue_pending(chan); > >+ while (fsl_dma_is_complete(chan, cookie, NULL, NULL) > >+ != DMA_SUCCESS); > > Again, is it possible to hang your thread here? > > [...] I'll add msleep here. Thanks! - zw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/