Date:   Fri, 24 Feb 2023 17:56:03 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Message-ID: <Y/j6MxmOkZj/TKej@sirena.org.uk>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
 <Y/jqCRAenwbqc1Uu@sirena.org.uk>
 <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1Y5caIOx58tpWex7"
Content-Disposition: inline
In-Reply-To: <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
Precedence: bulk


--1Y5caIOx58tpWex7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 24, 2023 at 04:50:00PM +0000, Krishna Yarlagadda wrote:

> > >  		msg->actual_length += xfer->len;
> > > +		if (!xfer->cs_change && transfer_phase == DATA_TRANSFER)
> > {
> > > +			tegra_qspi_transfer_end(spi);
> > > +			spi_transfer_delay_exec(xfer);
> > > +		}
> > >  		transfer_phase++;
> > >  	}
> > > -	if (!xfer->cs_change) {
> > > -		tegra_qspi_transfer_end(spi);
> > > -		spi_transfer_delay_exec(xfer);
> > > -	}

> > This looks like it'll do the wrong thing and do a change on every
> > transfer if cs_change isn't set?

> This condition is hit only in data phase which is end of message.

Shouldn't this just be moved into the DATA_TRANSFER case statement?

--1Y5caIOx58tpWex7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP4+jIACgkQJNaLcl1U
h9CuNAf/RnnVBXixt5TqUSG5Q9M0PuUVwE2dM/ySiYNHqJNe/wvfnMzahIoev4cd
5nSTnwqNPI4oLsPsYNsWUa306BdMmOKKK0nPibXbzIuCX2xEjY69OBqEQqg0A990
5CQpLlOLbEOy7+Ecnv8jmNuydgPu3F8Wxwzjw9ceD+P1viyE4514AuCL/9Oet02w
zuE3IDrSOSdjmakcsj5vUVktj3GFQXOgNBP/ex0aFZgJJq3IjtI5e8yINHiJZx52
DClt6OMO0zh/Gbob/aYGrp7+8df2CkAO4c85I8CAXwO3vsGfLv0qedlRGB9sd/BL
uhKhhhaB+MF56Tsf9WnDURGmxskHkg==
=amcU
-----END PGP SIGNATURE-----

--1Y5caIOx58tpWex7--