MIME-Version: 1.0
References: <20230224174007.13009-1-asmaa@nvidia.com>
In-Reply-To: <20230224174007.13009-1-asmaa@nvidia.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 24 Feb 2023 20:16:21 +0200
Message-ID: <CAHp75Vf_yHVhZS4ghZK5aZ7sQjdZ_1_MT=Ke6vVfUBRpL70-Eg@mail.gmail.com>
Subject: Re: [PATCH v1] gpio: mmio: handle "ngpios" properly in bgpio_init
To:     Asmaa Mnebhi <asmaa@nvidia.com>
Cc:     linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 24, 2023 at 7:40 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> bgpio_init uses "sz" argument to populate ngpio, which is not accurate.

bgpio_init() uses the

(Note parentheses, same for other func() mentions)

> Instead, read the "ngpios" property from the DT and if it
> doesn't exist, use the "sz" argument. With this change, drivers no
> longer need to overwrite the ngpio variable after calling bgpio_init.

Thank you!

...

> +       ret = device_property_read_u32(dev, "ngpios", &ngpios);
> +       if (!ret)
> +               gc->ngpio = ngpios;
> +       else
> +               gc->ngpio = gc->bgpio_bits;

This duplicates the GPIO library. What probably better to have is to
just check the property existence

device_property_present() and do accordingly.

-- 
With Best Regards,
Andy Shevchenko