Date:   Fri, 24 Feb 2023 10:57:29 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Hangyu Hua <hbh25y@gmail.com>
Cc:     borisp@nvidia.com, john.fastabend@gmail.com, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, ilyal@mellanox.com,
        aviadye@mellanox.com, sd@queasysnail.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: tls: fix possible info leak in
 tls_set_device_offload()
Message-ID: <20230224105729.5f420511@kernel.org>
In-Reply-To: <20230224102839.26538-1-hbh25y@gmail.com>
References: <20230224102839.26538-1-hbh25y@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 24 Feb 2023 18:28:39 +0800 Hangyu Hua wrote:
> After tls_set_device_offload() fails, we enter tls_set_sw_offload(). But
> tls_set_sw_offload can't set cctx->iv and cctx->rec_seq to NULL if it fails
> before kmalloc cctx->iv. It is better to Set them to NULL to avoid any
> potential info leak.

Please show clear chain of events which can lead to a use-after-free 
or info leak. And if you can't please don't send the patch.