Date:   Fri, 24 Feb 2023 19:15:01 +0000
From:   Mark Brown <broonie@kernel.org>
To:     =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado 
        <nfraprado@collabora.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: mt8192: Remove spammy log messages
Message-ID: <Y/kMtXmrIYoLNV8a@sirena.org.uk>
References: <20230223-asoc-mt8192-quick-fixes-v1-0-9a85f90368e1@kernel.org>
 <20230223-asoc-mt8192-quick-fixes-v1-1-9a85f90368e1@kernel.org>
 <20230224190657.edrvkg22gz5gff4g@notapiano>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="udvt/bvCvfnRf3US"
Content-Disposition: inline
In-Reply-To: <20230224190657.edrvkg22gz5gff4g@notapiano>
Precedence: bulk


--udvt/bvCvfnRf3US
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 24, 2023 at 02:06:57PM -0500, N=EDcolas F. R. A. Prado wrote:

> Probably the spammiest messages are=20

> [   33.881459] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_ru=
ntime_resume()
> [   33.889320] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_en=
able_clock()
> [   34.029456] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_ru=
ntime_suspend()
> [   34.041718] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_di=
sable_clock()

> from mt8192-afe-pcm.c, so I think it would make sense to get rid of those=
 in
> this commit as well.

They should definitely go as well, I don't know that there's a specific
need for it to be this commit though - it was mostly just what I noticed
while looking at the controls that were failing tests.

> Way less spammy, but there are also

> [  176.209790] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_h=
w_params(), id 43, rate 48000, channels 2, format 6, mclk_rate 24576000, bc=
k_rate 3072000
> [  176.224149] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_h=
w_params(), out_channels_per_sdata =3D 2
> [  180.272153] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_en_ev=
ent(), name TDM_EN, event 0x8
> [  180.281462] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_bck_e=
n_event(), name TDM_BCK, event 0x8, dai_id 43

> from mt8192-dai-tdm.c.

Yup.

> Anyway, if you prefer to keep only changes in the ADDA driver for this co=
mmit
> that's fine too, and I can send another patch removing these other ones l=
ater.

That'd be great, I will probably take more passes at this stuff at some
point but it's very much a background thing.

--udvt/bvCvfnRf3US
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP5DLUACgkQJNaLcl1U
h9DLFwf/YAM2Ep/kv6qQZQ6+TxtU7vTdLiprq5aQtl2WrtHV1TeDyqQh7kR9Li5D
75H051WimadBJSKxF19fHEd3ISMefuIYUhpQACpS0xyyN5Dg8kbp/Kfp2HdIWLsl
Kiptkup62x8YDVO1kVkyNrsJlimZU14yPx8OhPk475PB/pBXUXrozRiI9uwxHELc
/GiMndnDjS/xHRHqIBvg2wrSQYaZblAw8NBNL5wbgc99twQ04kftOceFoY+LDZ1y
ouTizm1i/w8ZtV9WjbQ2sq3/dMS3hSoXEMgQFcuZfyGdN/JTKKTwtg/2BiHr8k/J
3+69dA+Tg4vSKZjKrkiZs6ROKKxJ4w==
=J6dC
-----END PGP SIGNATURE-----

--udvt/bvCvfnRf3US--