Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66506C7EE2F for ; Fri, 24 Feb 2023 21:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjBXVGf (ORCPT ); Fri, 24 Feb 2023 16:06:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbjBXVGd (ORCPT ); Fri, 24 Feb 2023 16:06:33 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8249C6DDB7; Fri, 24 Feb 2023 13:06:28 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pVfGp-0002JD-34; Fri, 24 Feb 2023 22:06:24 +0100 Date: Fri, 24 Feb 2023 21:06:17 +0000 From: Daniel Golle To: Krzysztof Kozlowski Cc: linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Matthias Brugger , Krzysztof Kozlowski , Rob Herring , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Edward-JW Yang , Johnson Wang , Chun-Jie Chen , Miles Chen , Sam Shih Subject: Re: [PATCH RFC 1/4] dt-bindings: clock: rename mt7986-clk.h to mediatek,mt7986-clk.h Message-ID: References: <15d718a2d696d29b48668b9ab5531369c537a1e6.1677089171.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2023 at 11:18:37AM +0100, Krzysztof Kozlowski wrote: > On 22/02/2023 19:09, Daniel Golle wrote: > > Rename dt-bindings header file mt7986-clk.h to mediatek,mt7986-clk.h, > > propagate this change also to mt7986a.dtsi which is the only user. > > > > Signed-off-by: Daniel Golle > > --- > > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +- > > drivers/clk/mediatek/clk-mt7986-infracfg.c | 2 +- > > drivers/clk/mediatek/clk-mt7986-topckgen.c | 2 +- > > .../dt-bindings/clock/{mt7986-clk.h => mediatek,mt7986-clk.h} | 0 > > You cannot have bindings and DTS and drivers mixed together. Which > points to fact - you cannot make such change... Also your commit msg > does not justify "why" you are doing it. The reason is simply consistency with most other SoCs. So to make such a change possible, I should do it in three steps, right? Step 1: dt-bindings: copy mt7986-clk.h to mediatek,mt7986-clk.h Step 2: changes in drivers Step 3: dt-bindings: remove mt7986-clk.h Would this change be acceptable if carried out in 3 commits? And using the same strategy also the other changes suggested in the series? Thank you! Best regards Daniel