MIME-Version: 1.0
References: <20230224164519.2757173-1-trix@redhat.com>
In-Reply-To: <20230224164519.2757173-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 24 Feb 2023 17:22:40 -0500
Message-ID: <CADnq5_MNxZn+LEOg0L_0+zmMZ52qGCQi-KfMmuD_vSwt8rqJbQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: remove unused variable ring
To:     Tom Rix <trix@redhat.com>
Cc:     alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        ruijing.dong@amd.com, Jane.Jian@amd.com, James.Zhu@amd.com,
        tao.zhou1@amd.com, sonny.jiang@amd.com, leo.liu@amd.com,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Feb 24, 2023 at 11:45 AM Tom Rix <trix@redhat.com> wrote:
>
> building with gcc and W=3D1 reports
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:81:29: error: variable
>   =E2=80=98ring=E2=80=99 set but not used [-Werror=3Dunused-but-set-varia=
ble]
>    81 |         struct amdgpu_ring *ring;
>       |                             ^~~~
>
> ring is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/=
amdgpu/vcn_v4_0.c
> index 213b43670f23..023a1fffa6a9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -78,12 +78,10 @@ static void vcn_v4_0_set_ras_funcs(struct amdgpu_devi=
ce *adev);
>  static int vcn_v4_0_early_init(void *handle)
>  {
>         struct amdgpu_device *adev =3D (struct amdgpu_device *)handle;
> -       struct amdgpu_ring *ring;
>
>         if (amdgpu_sriov_vf(adev)) {
>                 adev->vcn.harvest_config =3D VCN_HARVEST_MMSCH;
>                 for (int i =3D 0; i < adev->vcn.num_vcn_inst; ++i) {
> -                       ring =3D &adev->vcn.inst[i].ring_enc[0];
>                         if (amdgpu_vcn_is_disabled_vcn(adev, VCN_ENCODE_R=
ING, i)) {
>                                 adev->vcn.harvest_config |=3D 1 << i;
>                                 dev_info(adev->dev, "VCN%d is disabled by=
 hypervisor\n", i);
> --
> 2.27.0
>