Date:   Sat, 25 Feb 2023 00:31:56 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Asahi Lina <lina@asahilina.net>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        asahi@lists.linux.dev
Subject: Re: [PATCH 2/3] rust: macros: concat_idents: Allow :: paths in the
 first argument
Message-ID: <20230225003156.4858d79e.gary@garyguo.net>
In-Reply-To: <20230224-rust-macros-v1-2-b39fae46e102@asahilina.net>
References: <20230224-rust-macros-v1-0-b39fae46e102@asahilina.net>
        <20230224-rust-macros-v1-2-b39fae46e102@asahilina.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kKfTlJNfwH7KS7/NrgmcTfAqmgiBOLS25l2x6T9/vKOCRuiHcZZaQBrg6/CT?=
 =?us-ascii?Q?LGfds62iE/W3v3qENotMHDrBQkaT00KJ9EgCCkLWvrwuexpstCpBNGCiphUl?=
 =?us-ascii?Q?iWUILL+s5TVfwPdsZ01clYtrdvjaMRiSp8vTHRwcd/KLGxVK6wegST/URU8b?=
 =?us-ascii?Q?S0kVV8s9oIlCCULrmcx3FGDZZpF+2/dguqua91vDqpuTl174Hvfd8i5K3twr?=
 =?us-ascii?Q?t7f4KF6iB8YupNGWQy6w6QajH1E0iMArP/MMUKQp8+0+9blTblGbAvPKu3P/?=
 =?us-ascii?Q?iFhAIVfzjzeFgfAIfWt5n9JOjLdxtSf2ntWEA+HwHuih2tpfkKsHIyAOLPLJ?=
 =?us-ascii?Q?ZSsHv0LXfjjWD3t2DdcFdFt95XoGtaBGxyCuabvFSyKSTRgrs38XMPTphBu7?=
 =?us-ascii?Q?d5sh6eYl79hcd18aOUbaOasO423sFpzJXKxZ7BIn6jK+GMt8r9G1WbfZR6oy?=
 =?us-ascii?Q?eliCgZF4IE4kgbW7lrMs9Hah4/rq4CA1B1SilXMDR7KtVy6rsMi3EL6KjczI?=
 =?us-ascii?Q?wJ+J5kRJkB0FLHf0Em1x4/TjOCrwFAFU/hdS55rJnt2Vd2K+20osK50zIJwr?=
 =?us-ascii?Q?wbMkIIKlDx7BKUuAjRoZjrQmF+5NLrjkMwet1V2+6cn/FW/VDOBiHsxwVi54?=
 =?us-ascii?Q?75JL/DG2AyP8x/CHTIqXg5WVMzO2EWHxsbKn5UeMuiPY41y9ocfBxYYWv44c?=
 =?us-ascii?Q?90g0KXcwtlsGARTe/mheZjNBf0AIkF9aAaoPaFzoTV8OpRPhSaHwJCHpNzQ9?=
 =?us-ascii?Q?TpmBIlosNdu2T9AM3dcJ2953rdx6sgLZWs3JeoECVuEbDIjhTGMuuRs+YFZX?=
 =?us-ascii?Q?l+/UmhQnXh0sflY+V19IaZaRY503/ilclTxlv06vJJ6gNNbcw5eZnhxhuWj0?=
 =?us-ascii?Q?qbxjXO1NvtzTHcPMD1ch4FUiH7BA8oPnvJlWT4xR5yFBLIQJs8iHAv7297U2?=
 =?us-ascii?Q?Me9nu3NPyhyx2vU+7alu7F+RQhf5Q4G0Mlt7YnJb8rk6aZd2qKYcvstNpxCX?=
 =?us-ascii?Q?IVoSWUpYy5d/oVsZkJTUk7mwt52oEpkxAzCbgGAwT15JoRFyBYuCy5LWFfZB?=
 =?us-ascii?Q?iLxPeELfCKsSefzUOykw4vMRezXJXVmW7QnfHkko27v8P5l/YeeibUET5jsB?=
 =?us-ascii?Q?a6eZOIjrSLJt5kwGQq0oOZelpo4V31UPSlCwYAILEK59VvawfvnXGC+DuA3J?=
 =?us-ascii?Q?cRQ0BQZSNn3UFR4rTfse//3FY+k1C5PoQTw+gcttDWYnQGxlHWAdO3sPewap?=
 =?us-ascii?Q?d86RiOB/qyisSLo35iuWa2vx7L827/W7fppLVI3jup3WFvEUfE/czB2cEfEa?=
 =?us-ascii?Q?V2JMWdbBnUTZzgG03oXgkuesjZJK72fiwrDYxItU4v4DJCH1843n58Em1HGc?=
 =?us-ascii?Q?KpxCSJi0r5DL3sOPStl0M8jaXIw+LlZ5HEk7Stk8uw2PdeGjxfS54Fth5Hm5?=
 =?us-ascii?Q?XvMbgyUTFWv6na0vy1kdN3FqWswI/YuxOKJ96VDvqqDRKlWrCtEnIpLy0ixB?=
 =?us-ascii?Q?3IdbZXss3GPDSB4eKxk6G30wyTeKVYiBNiAidDhhZ050BWQqe1SClr4pzq8z?=
 =?us-ascii?Q?TVlzFvjP+VfeoUjnPfD1T8USXst6pn5ZXy12DOoQ?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3510fdee-5617-4c4c-2c7f-08db16c7b413
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2023 00:31:57.9608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uwj0HxrlhiaDXo8rA6P/qxIHM1pu3y+VXSkwu3bjZfFQmBoYM7wCid8ft3oq5vWwuyzcN8nVJm+GXaZg1fEvNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO6P265MB6222
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 24 Feb 2023 16:25:56 +0900
Asahi Lina <lina@asahilina.net> wrote:

> This makes things like concat_idents!(bindings::foo, bar) work.
> Otherwise, there is no way to concatenate two idents and then use the
> result as part of a type path.

It seems weird to me that this is called `concat_idents` despite
working for more things than just idents.

How about just implement a simple version of the `paste` macro instead?

Best,
Gary

> 
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
>  rust/macros/concat_idents.rs | 24 +++++++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)
> 
> diff --git a/rust/macros/concat_idents.rs b/rust/macros/concat_idents.rs
> index 6d955d65016e..d6614b900aa2 100644
> --- a/rust/macros/concat_idents.rs
> +++ b/rust/macros/concat_idents.rs
> @@ -14,10 +14,28 @@ fn expect_ident(it: &mut token_stream::IntoIter) -> Ident {
>  
>  pub(crate) fn concat_idents(ts: TokenStream) -> TokenStream {
>      let mut it = ts.into_iter();
> -    let a = expect_ident(&mut it);
> -    assert_eq!(expect_punct(&mut it).as_char(), ',');
> +    let mut out = TokenStream::new();
> +    let a = loop {
> +        let ident = expect_ident(&mut it);
> +        let punct = expect_punct(&mut it);
> +        match punct.as_char() {
> +            ',' => break ident,
> +            ':' => {
> +                let punct2 = expect_punct(&mut it);
> +                assert_eq!(punct2.as_char(), ':');
> +                out.extend([
> +                    TokenTree::Ident(ident),
> +                    TokenTree::Punct(punct),
> +                    TokenTree::Punct(punct2),
> +                ]);
> +            }
> +            _ => panic!("Expected , or ::"),
> +        }
> +    };
> +
>      let b = expect_ident(&mut it);
>      assert!(it.next().is_none(), "only two idents can be concatenated");
>      let res = Ident::new(&format!("{a}{b}"), b.span());
> -    TokenStream::from_iter([TokenTree::Ident(res)])
> +    out.extend([TokenTree::Ident(res)]);
> +    out
>  }
>