Date:   Sat, 25 Feb 2023 00:43:40 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Asahi Lina <lina@asahilina.net>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        asahi@lists.linux.dev
Subject: Re: [PATCH 1/2] rust: sync: arc: implement Arc<dyn Any + Send +
 Sync>::downcast()
Message-ID: <20230225004340.3957288e.gary@garyguo.net>
In-Reply-To: <20230224-rust-arc-v1-1-568eea613a41@asahilina.net>
References: <20230224-rust-arc-v1-0-568eea613a41@asahilina.net>
        <20230224-rust-arc-v1-1-568eea613a41@asahilina.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E4WoAF+46I/gLZrtEh9vHLEghc526+JfcmwHJFrKdZIqsRgp2XedcTFQeQgB?=
 =?us-ascii?Q?UYbktKh5sO2n5PLGSMvxfwJMWTvEfRuTCYPmdOVWXKQLQ3f0lEwVxMNYAz/f?=
 =?us-ascii?Q?eKtoRlo5YSc3MyU2YX58mmsUeyDJ+AWJ+8mrmeqWqJa7u+HoebuB936ocEKa?=
 =?us-ascii?Q?p793FkARSfIRWyXbru32mnREBRhLIyvghERD+JlskcaYNQ7oqg3ZSvMdiKkA?=
 =?us-ascii?Q?lOf0eTWld00fBgr7Lesiid/mz9FNe4yokxLmDmS5MYVMslJvSXyVqBQhBo3C?=
 =?us-ascii?Q?0CL3naPqpNrE82HSFCQR+u2p0YwWUjl75Y5CASef5jiCLW+RKmss7ByPylOI?=
 =?us-ascii?Q?mxIx4oO+V8kbb5P7wyoRWhxQHp1CEwvtqxhe1Z5Fl8tQq1/94maSm95gBXom?=
 =?us-ascii?Q?ghg1YAi0B2IE3kmPeV2uQQOt3HydbUk6xhKJyliUT2FyRvx79fsZVBjCDuKt?=
 =?us-ascii?Q?XnGTfOnAXWxWbxOcpcNPXaA6Kam1MJ+D3O36yz3eMNZHZ6YsiZCip0G6GyLi?=
 =?us-ascii?Q?LlyssnbZvSvS/k3Q3cGK/HKpXozkESYpyz2azT6QWuSKemJRRd+/gRkPwOVL?=
 =?us-ascii?Q?Kz13q++F2CKjFMi/UvnRAgYE4gCTvjSkxq8ZoK/6HJzmezgW1V9IXiYJPmZ7?=
 =?us-ascii?Q?M+Do8iys+lGc16Xxgap3ZmrZY2a7oq5zC9rnNyRQjkMhSdumxkpewuk5Y6X1?=
 =?us-ascii?Q?xK7VpDb5FfKirX5sj5YVNglJZX4J67F3a3rHjViRl90/N48NhnOdV0U/9f0G?=
 =?us-ascii?Q?I177xzVesfuq1a9gc6F8DtVZMPdS9+EQos2qFFZMsQQ9f2iQdKUBT3GrBRre?=
 =?us-ascii?Q?vn2e1WaMGrZZ2JMx7001OVryN/yfPY8LlZKiiTBa3vywqXw1qsnzU48izCoi?=
 =?us-ascii?Q?xODZ6r7mFBWKIZSFnwamuZB3aIF1BaqQz8ZbfxijLGi8RzbWAgeOaci8O+jI?=
 =?us-ascii?Q?Y43CFRLxdeDYECODQYXDR6B4HpF3i2MsTSi1r4VJgWN8AT3aCwdoyr/kq2yg?=
 =?us-ascii?Q?c1yM+pszGgDB6RhQvVNuxDOxqWX3o6ZHBXsB+wkxaypZ+mml04yOIGLU+XEZ?=
 =?us-ascii?Q?5XD0Auko4weIDs5loAWQp+p6+yxek3GrJv5zMxbH6JL7FSmIr/0kMBQQ4lrw?=
 =?us-ascii?Q?aZiwodpyWQn7M0tVTds5ACRfvv2pSN/p77rxey90//aW5B+wQCHHhQg31i8Z?=
 =?us-ascii?Q?Z8fHAqKmfsE6eYl5/bhWhjaFfiFZ3Nr9F+9Ldm2xsI2NfRZSBpI7rOknYmeH?=
 =?us-ascii?Q?XRW13BX5SLrn4veYDxR6c71A5cl5q0njobj0VZmRol4/ra4B+nf9tuk/DO+l?=
 =?us-ascii?Q?mE/aObv3FJfRpFWxW6NdjmU9X0HQNoJak852WufDi7euk+cSmglgX4a87U5a?=
 =?us-ascii?Q?8t1yo9I7WUE/zEoLtzQ5N9hAjbyStIBINSvAiduScQQbSMOP/cgWbHn3DlV9?=
 =?us-ascii?Q?A6za/lHZ+AtoPtUnP7f4J7xXfDVhu/6oW/T94XpKaXU5fJBnvtyvokqoYtHh?=
 =?us-ascii?Q?nj8faXfUE/PKuPQsEaNflvM81bNDjcxUdOckpTOiAEkFC9Sa0kmguf+3+bCq?=
 =?us-ascii?Q?QpHZ+5qaRirREo+0GY8w+c55u54mUijDBzD/TpM1?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: d141fef4-d5f7-476c-2f8c-08db16c95779
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2023 00:43:41.5912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pNCg09CaJWSx2b3oKSY2EyGKUdPNWiyJsXVbRtk+BE/PhlWXMv9iV7Xy9BkdsvITNhXH2muTSpdji/R691mPVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5379
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 24 Feb 2023 16:59:33 +0900
Asahi Lina <lina@asahilina.net> wrote:

> This mirrors the standard library's alloc::sync::Arc::downcast().
> 
> Based on the Rust standard library implementation, ver 1.62.0,
> licensed under "Apache-2.0 OR MIT", from:
> 
>     https://github.com/rust-lang/rust/tree/1.62.0/library/alloc/src
> 
> For copyright details, please see:
> 
>     https://github.com/rust-lang/rust/blob/1.62.0/COPYRIGHT
> 
> Signed-off-by: Asahi Lina <lina@asahilina.net>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/sync/arc.rs | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index a94e303217c6..752bd7c4699e 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -22,6 +22,7 @@ use crate::{
>  };
>  use alloc::boxed::Box;
>  use core::{
> +    any::Any,
>      fmt,
>      marker::{PhantomData, Unsize},
>      mem::{ManuallyDrop, MaybeUninit},
> @@ -220,6 +221,27 @@ impl<T: 'static> ForeignOwnable for Arc<T> {
>      }
>  }
>  
> +impl Arc<dyn Any + Send + Sync> {
> +    /// Attempt to downcast the `Arc<dyn Any + Send + Sync>` to a concrete type.
> +    // Based on the Rust standard library implementation, ver 1.62.0, which is
> +    // Apache-2.0 OR MIT.
> +    pub fn downcast<T>(self) -> core::result::Result<Arc<T>, Self>
> +    where
> +        T: Any + Send + Sync,
> +    {
> +        if (*self).is::<T>() {
> +            // SAFETY: We have just checked that the type is correct, so we can cast the pointer.
> +            unsafe {
> +                let ptr = self.ptr.cast::<ArcInner<T>>();
> +                core::mem::forget(self);
> +                Ok(Arc::from_inner(ptr))
> +            }
> +        } else {
> +            Err(self)
> +        }
> +    }
> +}
> +
>  impl<T: ?Sized> Deref for Arc<T> {
>      type Target = T;
>  
>