Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DE3C7EE23 for ; Sat, 25 Feb 2023 07:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjBYHAc (ORCPT ); Sat, 25 Feb 2023 02:00:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBYHAa (ORCPT ); Sat, 25 Feb 2023 02:00:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E946D244B4; Fri, 24 Feb 2023 23:00:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2AA5609FE; Sat, 25 Feb 2023 07:00:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 891B1C433EF; Sat, 25 Feb 2023 07:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1677308428; bh=9DaSSSuAStTE38Q97iKS3CcvRFjMEQ5/vnkZFEYg3SE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XMIAM/1fyPQfueT7qOtYuSG9/ekWAAgoKyxKk0cHSFsnnExkLotQaSSZVn6wi36xm I7cIbbDr2V+ErQKxLJ0FjdmczNomwBO0NFzEABqU9Djbqz6NDaihOmOZ7nn86q4v29 x1Brl1tRqx/PRc53Zn8Ku2C+AGmLqG6vHVCyagdY= Date: Sat, 25 Feb 2023 08:00:24 +0100 From: Greg Kroah-Hartman To: Robin Murphy Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Will Deacon , Joerg Roedel , Hector Martin , Sven Peter , Arnd Bergmann , "Rafael J. Wysocki" , Alyssa Rosenzweig , Neal Gompa , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 2/5] rust: device: Add a minimal RawDevice trait Message-ID: References: <20230224-rust-iopt-rtkit-v1-0-49ced3391295@asahilina.net> <20230224-rust-iopt-rtkit-v1-2-49ced3391295@asahilina.net> <590134fc-a6fd-9d86-ba3f-c621332b65fc@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <590134fc-a6fd-9d86-ba3f-c621332b65fc@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2023 at 06:52:04PM +0000, Robin Murphy wrote: > > But again, let's see about disconnecting the iommu ops entirely from the > > device and just relying on the bus, that should work better, rigth? > > Um, other way - iommu_ops have almost finished moving *off* the bus to be > per-device. You acked the patch the other week and seemed pleased with it ;) Oops, yes, sorry, I meant the other way around in my comment, see, it's confusing :) And yes, I want to see your patch series merged, it will make my "clean up the driver core lifetime rules" work a lot easier, is it still planned for 6.3-rc1? > But either way that's orthogonal to this case, since the device that > io-pgtable deals with cannot have iommu_ops of its own (it *is* the IOMMU, > or at least a GPU MMU acting as one). Agreed, and thanks for the detailed explaination, it makes more sense now. But I still think the pointer reference needs to be incremented when saved off to be at least a bit more sane. thanks, greg k-h