From:   Armin Wolf <W_Armin@gmx.de>
To:     rafael@kernel.org, lenb@kernel.org
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] ACPI: SBS: Fix various issues
Date:   Sat, 25 Feb 2023 09:04:54 +0100
Message-Id: <20230225080458.1342359-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:dSVCL8zROyo=;NJEm1JrBIRHjsuLxO3CDvJfpPMV
 oE15vJHUS6IOpFyjNdZ5zKgfpyRKiGU66lSmm/XEJ8gHCoMQZoTyoao/3ZV47pMCByowjvcpy
 Onz7Akvq4aQ8eh4xj7Dx3mmn5P+IO4/S0kTAnM4yliqDIH99uhKTVyZgB6b7N9QFFT4wUvTk4
 S2UUPJf7JICTw1PwSJYqJg5yqr0IJC9M+L6XA8j7o4Z9hcH7HQRQSX842YZ6t3IPYTmfqGZNW
 +BXX+PPC8HpwTprd5rhiL+cyyXyTur2/ubihIJzoY4Thv36glYDJeJ7wAkHpfbit9mqc6Y/09
 2shu8l8agpvRotvBlf8Hcj8Elqw7Lb0GeKaNOX5aX6sadV3DVvKZTZqDABMSRBUAt3PQdXnae
 fSIzA2+RIDDmK/7LW4yuYtUxocQ2vp3UQzwTnNP3zdtH0pbsoGUrDCBQxv8iZfanULKpcWL7I
 /B/viTuBmujLfgJLWYjE9tdtqgDcY5HkuEYlSC9QZZBN2oBN/0J6Z+4nBeakMN4z8U5qbmzgf
 ULFZ0PH+UkxY3eJvgwyLJUKb6r6L4KhtwwCjaabOdWExodGGTqEo8wDIA9MCb4aKqP9T1yrr8
 CzfOgjgLp5eqkeYRKNxaiMSkxFuUQF8ksM7ex2NFtkQViJ+IdT57vmIHpHSPc5kpy2I972Dor
 LNHfxquznfcbQ3t3oIoGsLvhNj+euJDlIYug+atIUYeE5ahCn5HtsyzDX/DR4/hefcSEETh+Y
 nG1uL5SD0CTm7jyseYABW8Shbtx3r/LQfVKAFki9btRtSTMwfA23qjjRRV7xOfRwPE6veEVHm
 rk+gd5m5S+HlDzSmsqTQKqfv6Vzt1nLnn8UfOpGk15tOzKb6ds4lETNJ5QFxExkf6SZxgkaIB
 7Y0x4M4+1vD03eeF8ToHo+5ce5RVz8ZQdkmXIwqElFZT79UgWvXA3l85GRtruOI6z+t0ZVtku
 TnCnvO5gCVx0MucaJycVGaI9S8w=
Precedence: bulk

On my Acer Travelmate 4002WLMi, the system locks up upon
suspend/shutdown. After a lot of research, it turned out
that the sbs module was the culprit. The driver would not
correctly mask out the value used to select a battery using
the "Smart Battery Selector" (subset of the "Smart Battery Manager").
This accidentally caused a invalid power source to be selected,
which was automatically corrected by the selector. Upon
notifing the host about the corrected power source, some batteries
would be selected for re-reading, causing a endless loop.
This would lead to some workqueues filling up, which caused the
lockup upon suspend/shutdown.

The first three patches fix a stacktrace on module removal caused
by some locking issues. The last patch finally fixes the
suspend/shutdown issues.

As a side note: This was the first machine on which i installed Linux,
to finally fixing this took ~5 years of tinkering.

Armin Wolf (4):
  ACPI: EC: Add query notifier support
  ACPI: sbshc: Use ec query notifier call chain
  ACPI: EC: Make query handlers private
  ACPI: SBS: Fix handling of Smart Battery Selectors

 drivers/acpi/ec.c       | 44 ++++++++++++++++++++--------------------
 drivers/acpi/internal.h | 10 ++++-----
 drivers/acpi/sbs.c      | 27 ++++++++++++++++---------
 drivers/acpi/sbshc.c    | 45 ++++++++++++++++++++++++++---------------
 4 files changed, 74 insertions(+), 52 deletions(-)

=2D-
2.30.2