MIME-Version: 1.0
References: <20230222163754.3711766-1-frank.jungclaus@esd.eu>
In-Reply-To: <20230222163754.3711766-1-frank.jungclaus@esd.eu>
From:   Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date:   Sat, 25 Feb 2023 17:34:37 +0900
Message-ID: <CAMZ6RqJwJNxn5nm-PW2yY3BobTNB+vVmeDGi=M80YavN8Ui-OQ@mail.gmail.com>
Subject: Re: [PATCH] can: esd_usb: Improve code readability by means of
 replacing struct esd_usb_msg with a union
To:     Frank Jungclaus <frank.jungclaus@esd.eu>
Cc:     linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
        Wolfgang Grandegger <wg@grandegger.com>,
        =?UTF-8?Q?Stefan_M=C3=A4tje?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu. 23 Feb. 2023 at 01:56, Frank Jungclaus <frank.jungclaus@esd.eu> wrote:
> As suggested by Vincent Mailhol, declare struct esd_usb_msg as a union
> instead of a struct. Then replace all msg->msg.something constructs,
> that make use of esd_usb_msg, with simpler and prettier looking
> msg->something variants.
>
> Link: https://lore.kernel.org/all/CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@mail.gmail.com/
> Suggested-by: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>

Thank you for your follow up on this and on all my other comments.

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>