MIME-Version: 1.0
References: <20230215012034.403356-1-masahiroy@kernel.org> <20230215012034.403356-7-masahiroy@kernel.org>
 <Y/k9VkL+Amj8JaSe@fjasle.eu>
In-Reply-To: <Y/k9VkL+Amj8JaSe@fjasle.eu>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 25 Feb 2023 17:54:40 +0900
Message-ID: <CAK7LNATb=zyH_0Rf6XXh5iyNaT09gfZH+2mX+ano6pv0120QfA@mail.gmail.com>
Subject: Re: [PATCH v6 07/12] kbuild: deb-pkg: switch over to source format
 3.0 (quilt)
To:     Nicolas Schier <nicolas@fjasle.eu>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ben Hutchings <ben@decadent.org.uk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Feb 25, 2023 at 7:48 AM Nicolas Schier <nicolas@fjasle.eu> wrote:


>
> bike-shedding:
>
>         cat <<-eof
>         Subject: Add .config
>         Author: ${maintainer}
>
>         --- /dev/null
>         +++ linux/.config
>         eof


I agree this is more readable, but I used echo to
avoid a process fork.

'echo' is a shell built-in for bash and dash but 'cat' is not.

So, this is a trade-off between readability vs
one less process fork.

If the code were much longer, I would prefer 'cat'.


>
> > +     diff -u /dev/null "${KCONFIG_CONFIG}" | tail -n +3
> > +} > debian/patches/config
> > +echo config > debian/patches/series
> >
> >  echo $debarch > debian/arch
> >  extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev:native)"
> > --
> > 2.34.1
>
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>


--
Best Regards
Masahiro Yamada