Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0654FC7EE2D for ; Sat, 25 Feb 2023 10:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbjBYKdb (ORCPT ); Sat, 25 Feb 2023 05:33:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjBYKd3 (ORCPT ); Sat, 25 Feb 2023 05:33:29 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF1E016AE7; Sat, 25 Feb 2023 02:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677321208; x=1708857208; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3nEvCLA4JQQ360nMw6uKb2h+Cybm87DOEWQ45Tw8cb8=; b=aVXDaTmTW3XTNyPPi2aLhkmJGrX5KctzMGNmAQnuRQ6p7K/F/8jpdwc5 QYDxr310PpfsO48jzA6QofXPfZ+rtI7d8fT1+lSIfggJAZRMB8O8j7U2b 2wwxC+sV7SGXFSZC7NB0Kb47CSdr+9QwkcFEnsEE8ArUykY1UB3OAxbn/ JAAIXqquu0+EVJOywj/eX3+IVDe6miY75ICeDkfMhWfqYYDCAwZNvrxQH GwkiA+3efz3ToYoacMyhVaHvevS5+KzmVzQxfdm3ykQENxyEOoqujMt+a 7kqJTN9pJ11IJ7k87k11HyLkiBXG5rfeCJOMrhTJfYXwABeN9niZ1+I/t g==; X-IronPort-AV: E=McAfee;i="6500,9779,10631"; a="361163975" X-IronPort-AV: E=Sophos;i="5.97,327,1669104000"; d="scan'208";a="361163975" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2023 02:33:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10631"; a="675230355" X-IronPort-AV: E=Sophos;i="5.97,327,1669104000"; d="scan'208";a="675230355" Received: from lkp-server01.sh.intel.com (HELO 3895f5c55ead) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 25 Feb 2023 02:33:27 -0800 Received: from kbuild by 3895f5c55ead with local (Exim 4.96) (envelope-from ) id 1pVrrq-00037H-0Y; Sat, 25 Feb 2023 10:33:26 +0000 Date: Sat, 25 Feb 2023 18:32:36 +0800 From: kernel test robot To: Armin Wolf , rafael@kernel.org, lenb@kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ACPI: EC: Make query handlers private Message-ID: <202302251812.I1FHOAnh-lkp@intel.com> References: <20230225080458.1342359-4-W_Armin@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230225080458.1342359-4-W_Armin@gmx.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Armin, I love your patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on linus/master v6.2 next-20230225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Armin-Wolf/ACPI-EC-Add-query-notifier-support/20230225-160641 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20230225080458.1342359-4-W_Armin%40gmx.de patch subject: [PATCH 3/4] ACPI: EC: Make query handlers private config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20230225/202302251812.I1FHOAnh-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/a62cb9e29bf040af617070fa775758720d2de12e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Armin-Wolf/ACPI-EC-Add-query-notifier-support/20230225-160641 git checkout a62cb9e29bf040af617070fa775758720d2de12e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202302251812.I1FHOAnh-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/acpi/ec.c:1083:5: warning: no previous prototype for 'acpi_ec_add_query_handler' [-Wmissing-prototypes] 1083 | int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit, acpi_handle handle) | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/acpi_ec_add_query_handler +1083 drivers/acpi/ec.c 1082 > 1083 int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit, acpi_handle handle) 1084 { 1085 struct acpi_ec_query_handler *handler = 1086 kzalloc(sizeof(struct acpi_ec_query_handler), GFP_KERNEL); 1087 1088 if (!handler) 1089 return -ENOMEM; 1090 1091 handler->query_bit = query_bit; 1092 handler->handle = handle; 1093 mutex_lock(&ec->mutex); 1094 kref_init(&handler->kref); 1095 list_add(&handler->node, &ec->list); 1096 mutex_unlock(&ec->mutex); 1097 return 0; 1098 } 1099 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests