Message-ID: <c45a0c45-ed87-636f-aa68-3d7ff81b83b6@collabora.com>
Date:   Sat, 25 Feb 2023 18:21:32 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v1 1/1] drm/virtio: Support sync objects
Content-Language: en-US
From:   Dmitry Osipenko <dmitry.osipenko@collabora.com>
To:     David Airlie <airlied@redhat.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>,
        =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <maraeo@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org
References: <20230119004143.968942-1-dmitry.osipenko@collabora.com>
 <20230119004143.968942-2-dmitry.osipenko@collabora.com>
In-Reply-To: <20230119004143.968942-2-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/19/23 03:41, Dmitry Osipenko wrote:
> +		ret = drm_syncobj_find_fence(file, syncobj_desc.handle,
> +					     syncobj_desc.point, 0, &in_fence);
> +		if (ret)
> +			break;
> +
> +		if (!dma_fence_match_context(in_fence, fence_ctx + ring_idx))
> +			ret = dma_fence_wait(in_fence, true);

I missed to add dma_fence_chain_contained(in_fence) here, otherwise the
match always fails for a chained fence.

-- 
Best regards,
Dmitry