Date:   Sat, 25 Feb 2023 17:08:17 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, paulb@nvidia.com, marcelo.leitner@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/sched: cls_api: Move call to
 tcf_exts_miss_cookie_base_destroy()
Message-ID: <Y/oycX7fMP8yJAdd@corigine.com>
References: <20230224-cls_api-wunused-function-v1-1-12c77986dc2d@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230224-cls_api-wunused-function-v1-1-12c77986dc2d@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s5dO44cIvHekjr1mhndV3EcaYY9w9Dug4el8WgjEGMrJXu//PS8ihpWIKx0E?=
 =?us-ascii?Q?w6VhcYfBIN4Lzg0wKoo6NUl8suc1LvU+NTOcZWpN2ZtkXqAoooWNFI76RX8R?=
 =?us-ascii?Q?6Gbq0fE5fvI0OeMZL3KkqnWZd4kcpJdm/03vyPO0+S5JwF4x8VgAu2TsgtiD?=
 =?us-ascii?Q?vSA+AYqzZbs0et9QPW4Y61Dqbix3nov2KWkJRwx4q24UZf6z5U3dT5gGnZnY?=
 =?us-ascii?Q?X12OqFn1C1VvtRfKj2zQbpPEwQrkyPL1kfmcdLqpXLdvdzuqGfUIpF3WcFd6?=
 =?us-ascii?Q?h6XtmetkGxXTSS3d11JBCbUMpvAI/LNmGXLCTg1dH9Mn/Zz/jmoVW8U4q4/Y?=
 =?us-ascii?Q?Dh6ph6ZI5wCHAWlC6sdIGiWr2xETdAO1AaN98iENhSYSz9ZWOyBbOtw369rA?=
 =?us-ascii?Q?sLcC38Mx1telkvT8KK63nOVubKe1/uu2X5JQh8PSKpXquyY9MqWgzIv2G/uu?=
 =?us-ascii?Q?v80djFV3oY56wxpqF0n9FmZKKbJpjP7wxCtgSG9/PdEp8Wuswlqm556EIJxJ?=
 =?us-ascii?Q?EmDAdRsXw8Gwi2c71P/i17pGY0cC4ym2lX4hbVEIi/TFBFQrnXhXd2qDY5uY?=
 =?us-ascii?Q?+6pZ4qXjMrXnfcTLOBpQzwYQ7MSIWeOgQDhFGxh9f/C9iYyQ077pI7lc8GYF?=
 =?us-ascii?Q?Pwpk4q6qNq7qLY8m+OO1+NtGwvt3IQvBSPKbEpNDCSQLZLEVMRvMoPwWdlpR?=
 =?us-ascii?Q?UstEl3Qw004HKq5wDNoCPLOz5PKepNTZShuLxpnq63DOIgTG8BUd2DiP3rgc?=
 =?us-ascii?Q?pa1+hD6aN+jVCLz9ISk1+de9gcpm0o6+/lAhiIVLA4kLJW61mNw3TtYP2NMu?=
 =?us-ascii?Q?lGjUvIxIYA/obgNLQQx2WvvGHjEWpbnmNgwBtNT/3qgAKj+oJ57yskBGLvw7?=
 =?us-ascii?Q?CNzW6HEbP2sJlgr0UcTsbqAmL4WqKJPQI4LAvE5gsmpRu1xA/Fx2I4YYMhEj?=
 =?us-ascii?Q?fOe1bJwARjp0wnwKRs5etbF14RUTZUDUx89SrCxuOUFtbKPnZPJDw4RdVLRU?=
 =?us-ascii?Q?N3CVVjlIdspFWNH3a7Lf0SPC4VjE4uTMHw8rPnCAF2y30tPJIuqV5Rn2hKYB?=
 =?us-ascii?Q?zE/rBmKy/yaJlfkS2E0GbmaTgpxC2hwHtMlszsUSqtXkyQdoN/Z2DVoEkxiF?=
 =?us-ascii?Q?mRk9jNendb4hK5HuPAlZKmVYwWQKweOJJHGU2kSyJD7BBeblZSk8dL2kR1tr?=
 =?us-ascii?Q?SP9h+HPbkbzFN9KeFybpQNrzXiteulsAOH7Ca5p7rBLKwbiI2XNARr/QpPgH?=
 =?us-ascii?Q?I0owuLZktnfUdnXI0yiq9j1geENs1etD9OvOZCcz3Ou96kLC4dzdK+NVIuMY?=
 =?us-ascii?Q?+3LvBXWd32Ztb5CrD13uMABvUoh2zxfu8tSxNvSFuR2HsOZn7YuthDh1InOu?=
 =?us-ascii?Q?750Q3fiqfbgP007K0joQml43Ovetu0dHZTKwwZGwoJyQT+6iDlOPuU967pCR?=
 =?us-ascii?Q?S9GxtNfNXWhICMp0P79zALl/FFMLZdJit3wkRdeaDrEtsSX0leuWYdOKfHk1?=
 =?us-ascii?Q?0/TXw9SKXHjMd2H8LAQ1mla9CcH6cZSme+6eP/f4aETcIno4DNPoxMd2Y8fu?=
 =?us-ascii?Q?RFhjPR+2vy+pNN5jXDVqx8fHTnjDwQ8ChliQ6ulv8gWLiJiPFmDGoWN6gJm+?=
 =?us-ascii?Q?oHHCiASNbUGte70DP4WSPrLUiN7vP8LqStYPb3KMf39oUwPRvZfsQ1Esw+Dp?=
 =?us-ascii?Q?fcvH8g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 841c2975-198f-498b-80e4-08db174a869c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2023 16:08:25.8354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yF46HdyulOtYPYFtvD2Jfx3CqSeynKJTus+aGfQHt21nBglnY5erjUEowH+cvMG2+aSYP+Xt6OPxLDkqEdThnpVoxuHFJE+tVxpUuDMpWDw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5921
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 24, 2023 at 11:18:49AM -0700, Nathan Chancellor wrote:
> When CONFIG_NET_CLS_ACT is disabled:
> 
>   ../net/sched/cls_api.c:141:13: warning: 'tcf_exts_miss_cookie_base_destroy' defined but not used [-Wunused-function]
>     141 | static void tcf_exts_miss_cookie_base_destroy(struct tcf_exts *exts)
>         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Due to the way the code is structured, it is possible for a definition
> of tcf_exts_miss_cookie_base_destroy() to be present without actually
> being used. Its single callsite is in an '#ifdef CONFIG_NET_CLS_ACT'
> block but a definition will always be present in the file. The version
> of tcf_exts_miss_cookie_base_destroy() that actually does something
> depends on CONFIG_NET_TC_SKB_EXT, so the stub function is used in both
> CONFIG_NET_CLS_ACT=n and CONFIG_NET_CLS_ACT=y + CONFIG_NET_TC_SKB_EXT=n
> configurations.
> 
> Move the call to tcf_exts_miss_cookie_base_destroy() in
> tcf_exts_destroy() out of the '#ifdef CONFIG_NET_CLS_ACT', so that it
> always appears used to the compiler, while not changing any behavior
> with any of the various configuration combinations.
> 
> Fixes: 80cd22c35c90 ("net/sched: cls_api: Support hardware miss to tc action")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks Nathan,

I think the #ifdefs in this file could do with some work.
But as a fix this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>