Date:   Sat, 25 Feb 2023 17:56:22 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sean Anderson <seanga2@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 1/7] net: sunhme: Just restart
 autonegotiation if we can't bring the link up
Message-ID: <Y/o9tr8bV/eW4xOI@corigine.com>
References: <20230222210355.2741485-1-seanga2@gmail.com>
 <20230222210355.2741485-2-seanga2@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230222210355.2741485-2-seanga2@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gGuuAKxKWeo9wPis/iPJsC6s5HKJKKB/RLXuqhfvL7YdcW98FGq04vKfHx1n?=
 =?us-ascii?Q?XP9PBj+SaznUgc/GoPi+3cWElYg7g1HY37qZgf5GPah9eGVrJSa93rcZuFQG?=
 =?us-ascii?Q?XzOinAOvSZvw3a7eK3ERMirkQcEtAcN6S5c4aiAqy6GbeLvHWRfGBpy0wh6T?=
 =?us-ascii?Q?afB5fxKyEsyWdtJfUVOswRIROCDT5zdFOZ/Hl9/JycCXGsAhkf9K+t2zRjgi?=
 =?us-ascii?Q?DgVB0p+yNzOBXG5iJfSmx0wL0G6fGeeKe8R6ae8/LHQ3t9qTwa+mNfWugTbO?=
 =?us-ascii?Q?O7DS/hOEhN/UvkJSUuOHxsuBqXOB7RFjpZoFHhYaJpdfxE/D7hmg6PnB2fJL?=
 =?us-ascii?Q?srOe3ocT2icmHuyrFiJVi85ct+8/Yu+uxRacW7HxUpsYfdG/TxKC43QJZ1+e?=
 =?us-ascii?Q?6Q3nvAUYysx1ZhbZvFpxA+NljfvxE5irL8wuAs8fd1y01aFGpSiLX+kBBPel?=
 =?us-ascii?Q?p9CPKanaIOaEAwYc3GfIyZvnaTG3HY508qEjB+3Gf/AXD+FiM2hgELODVq9b?=
 =?us-ascii?Q?lqU0AEG4SvrD5xS3B/etHv8Awcdq66+u91V9kg5TTozCJ6gItYpEnLS2qfoq?=
 =?us-ascii?Q?l84Kyn3qb+ZG5xZtgr5NxSki/JivQaR1WKBKbpL16N4FuaQjE7/gIUp2OD+s?=
 =?us-ascii?Q?bO3SEzBW77cfCTifYC4id8NHKsxik2OF7j4TZP1ntD3AK87LgTxFLg4U0znA?=
 =?us-ascii?Q?WQjpc3mI1gyi4/bnJN3+WH6ds1dxxjG3u8VTxHPguGofsgyNxevyjvDo0QlK?=
 =?us-ascii?Q?10uTR4atUx6MSDkqrLhujK93lVAf7JKHSvx4Jrv0vLRrcJp6YlPBp0fjbyKn?=
 =?us-ascii?Q?Bmm14xBLYAnu+Si422qWJCMALWwjBl9MILjQqcFaEQHroVgyLe2eR6f232H2?=
 =?us-ascii?Q?oq1cPyBB1k6FHgX7vHc3Aco4TaV7Vw6ZTs4tTzyx2zIsjGgP68n9BqW7VUKJ?=
 =?us-ascii?Q?KwSPgcu2dEH0y/XKdgFQ6rv+5prhtPzSTG1+W33dR91XrxTczv0oONu+sdE4?=
 =?us-ascii?Q?jA4tZqTCZr7sPBcck/snmAOgqO0XjK/lzoTa3h145cAec4/+/0ojpEEKYQL5?=
 =?us-ascii?Q?UAfrM0X7bjZRv+2ewI08DBCXjaESozSQi0C7XHd3hCrZ70+8MFRJ2Ov3LiLq?=
 =?us-ascii?Q?HeuAYjgE7mq5vb0sKvLFfOnobgHzZlp9YjASfg89GWefdKqitjGDYtkX7oP0?=
 =?us-ascii?Q?OyYuaS8QVzudoVKsVAMRqs07PiQ8ZyYaYrVzTUFfTlYL1KVNjHtQHID26jT/?=
 =?us-ascii?Q?qwFMFtsWLeROlQlbZ118GxE7VtRL6xGsPSyvbRuUC8Ig2jrNsURc0Fi+Odn5?=
 =?us-ascii?Q?F79jNKJzL4dTMRYMJONjgew8BGlVc4TE6mwHcRowYuor7RzbmI3obPpRKWs6?=
 =?us-ascii?Q?HhP9Xo1RlC4pgM/gm5BsyG59C2RapKGtwVQIbzZZ03DpNXd7Z/qiCL9fdOKW?=
 =?us-ascii?Q?U5NrLTVXpuDkVSXKlqO4bb14UwY5sMe/9G/CV1cUtpiA41XZDPvJHt414zAP?=
 =?us-ascii?Q?8DTCQlROPlDabcmAufPZ4bDzKz+YbfOzWQLPPsnsPZnGiua7oItWH4fFGaBm?=
 =?us-ascii?Q?vsQiCb9siLWw3JBUh6uwCuuDMoh1C/KsG7NE00Z855bwMKeKAXIUYp6weysp?=
 =?us-ascii?Q?uMi7ZRO2AM8Ii5z3U7YNGsjO1wkjw7HK9TkjqOziuJn/WMnwi9ML/9/bvs1x?=
 =?us-ascii?Q?NBXXfA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8204d53-35fb-4790-a2d5-08db17513d09
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2023 16:56:28.8450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +05yC0o+KvI797JnlU9M0Wcl7puOrv3ycYNLJhuJXhSGEsZmsVLFsBh0EByxC22wN3f7My3uX7srUH5wQjwK2wCeMnjdnTIwD4wjY5OGXRg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3892
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 22, 2023 at 04:03:49PM -0500, Sean Anderson wrote:
> If we've tried regular autonegotiation and forcing the link mode, just
> restart autonegotiation instead of reinitializing the whole NIC.
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
> 
>  drivers/net/ethernet/sun/sunhme.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index dd14114cbcfb..3eeda8f3fa80 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -589,7 +589,10 @@ static int set_happy_link_modes(struct happy_meal *hp, void __iomem *tregs)
>  	return 1;
>  }
>  
> -static int happy_meal_init(struct happy_meal *hp);
> +static void
> +happy_meal_begin_auto_negotiation(struct happy_meal *hp,
> +				  void __iomem *tregs,
> +				  const struct ethtool_link_ksettings *ep);

I think it is preferable, though far more verbose, to move
happy_meal_begin_auto_negotiation() before happy_meal_timer and avoid the
need for a forward declaration. I did try this locally, and it did
compile.

>  static int is_lucent_phy(struct happy_meal *hp)
>  {
> @@ -743,12 +746,7 @@ static void happy_meal_timer(struct timer_list *t)
>  					netdev_notice(hp->dev,
>  						      "Link down, cable problem?\n");
>  
> -					ret = happy_meal_init(hp);
> -					if (ret) {
> -						/* ho hum... */
> -						netdev_err(hp->dev,
> -							   "Error, cannot re-init the Happy Meal.\n");
> -					}
> +					happy_meal_begin_auto_negotiation(hp, tregs, NULL);
>  					goto out;
>  				}
>  				if (!is_lucent_phy(hp)) {
> -- 
> 2.37.1
>