MIME-Version: 1.0
References: <20220621081506.50096-1-jiaming@nfschina.com>
In-Reply-To: <20220621081506.50096-1-jiaming@nfschina.com>
From:   Matt Turner <mattst88@gmail.com>
Date:   Sat, 25 Feb 2023 21:06:57 -0500
Message-ID: <CAEdQ38EDxV=K-kxB=u0Z+YRaBr1yTT7iN5gzhxw6-QJo+n9y3Q@mail.gmail.com>
Subject: Re: [PATCH] alpha: Add some spaces to ensure format specification
To:     Zhang Jiaming <jiaming@nfschina.com>
Cc:     rth@twiddle.net, ink@jurassic.park.msu.ru,
        linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
        liqiong@nfschina.com, renyu@nfschina.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 21, 2022 at 4:15 AM Zhang Jiaming <jiaming@nfschina.com> wrote:
>
> Add a space after ','.
> Add spaces around the '=', '>' and '=='.
>
> Signed-off-by: Zhang Jiaming <jiaming@nfschina.com>
> ---
>  arch/alpha/boot/stdio.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/alpha/boot/stdio.c b/arch/alpha/boot/stdio.c
> index 60f73ccd2e89..e6d1ebff4209 100644
> --- a/arch/alpha/boot/stdio.c
> +++ b/arch/alpha/boot/stdio.c
> @@ -42,8 +42,8 @@ static int skip_atoi(const char **s)
>
>  static char * number(char * str, unsigned long long num, int base, int size, int precision, int type)
>  {
> -       char c,sign,tmp[66];
> -       const char *digits="0123456789abcdefghijklmnopqrstuvwxyz";
> +       char c, sign, tmp[66];
> +       const char *digits = "0123456789abcdefghijklmnopqrstuvwxyz";
>         int i;
>
>         if (type & LARGE)
> @@ -83,14 +83,14 @@ static char * number(char * str, unsigned long long num, int base, int size, int
>                 precision = i;
>         size -= precision;
>         if (!(type&(ZEROPAD+LEFT)))
> -               while(size-->0)
> +               while (size-- > 0)
>                         *str++ = ' ';
>         if (sign)
>                 *str++ = sign;
>         if (type & SPECIAL) {
>                 if (base==8)
>                         *str++ = '0';
> -               else if (base==16) {
> +               else if (base == 16) {
>                         *str++ = '0';
>                         *str++ = digits[33];
>                 }
> @@ -125,7 +125,7 @@ int vsprintf(char *buf, const char *fmt, va_list args)
>                                 /* 'z' changed to 'Z' --davidm 1/25/99 */
>
>
> -       for (str=buf ; *fmt ; ++fmt) {
> +       for (str = buf ; *fmt ; ++fmt) {
>                 if (*fmt != '%') {
>                         *str++ = *fmt;
>                         continue;
> @@ -296,7 +296,7 @@ int sprintf(char * buf, const char *fmt, ...)
>         int i;
>
>         va_start(args, fmt);
> -       i=vsprintf(buf,fmt,args);
> +       i = vsprintf(buf, fmt, args);
>         va_end(args);
>         return i;
>  }
> --
> 2.25.1
>

Thanks for the patch! This was included in my pull request today and
is now upstream in Linus' tree.