MIME-Version: 1.0
References: <20230225113712.340612-1-alistair@alistair23.me>
 <20230225113712.340612-4-alistair@alistair23.me> <CAOMZO5COg7wZbG3aWcwMsvTBQ9Ft8CQ9wearXMh+00o29CTaeg@mail.gmail.com>
In-Reply-To: <CAOMZO5COg7wZbG3aWcwMsvTBQ9Ft8CQ9wearXMh+00o29CTaeg@mail.gmail.com>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Sun, 26 Feb 2023 15:52:19 +1000
Message-ID: <CAKmqyKPuuHcqYqNinrSfziN1+=5bVTyg=8eZh5j=yYS3BEWMRA@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Alistair Francis <alistair@alistair23.me>, s.hauer@pengutronix.de,
        devicetree@vger.kernel.org, shawnguo@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de,
        kernel@pengutronix.de, jernej.skrabec@gmail.com,
        linux@armlinux.org.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Feb 26, 2023 at 6:37 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Sat, Feb 25, 2023 at 8:37=E2=80=AFAM Alistair Francis <alistair@alista=
ir23.me> wrote:
>
> > +&i2c2 {
> > +       clock-frequency =3D <100000>;
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_i2c2>;
> > +       status =3D "okay";
> > +
> > +       bd71815: pmic@4b {
> > +               compatible =3D "rohm,bd71815";
> > +               reg =3D <0x4b>;
> > +               pinctrl-names =3D "default";
> > +               pinctrl-0 =3D <&pinctrl_bd71815>;
> > +               interrupt-parent =3D <&gpio6>; /* PMIC_INT_B GPIO6_IO16=
 */
> > +               interrupts =3D <16 IRQ_TYPE_LEVEL_LOW>;
> > +               gpio-controller;
> > +               clocks =3D <&clks IMX7D_CLKO2_ROOT_SRC>;
> > +               clock-output-names =3D "bd71815-32k-out";
> > +               #clock-cells =3D <0>;
> > +               #gpio-cells =3D <1>;
>
> The binding document says #gpio-cells =3D <2>;

Fixed!

>
> > +
> > +               regulators {
> > +                       #address-cells =3D <1>;
> > +                       #size-cells =3D <0>;
> > +
> > +                       buck1_reg: regulator@0 {
> > +                               reg =3D <0>;
>
> The regulator@0 and reg should not be present.

Fixed

>
> Please check Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml

Thanks, I double checked my latest code against the bindings.

Alistair