Date:   Sun, 26 Feb 2023 10:17:52 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Munehisa Kamata <kamatam@amazon.com>
Cc:     thierry.reding@gmail.com, tobetter@gmail.com,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] pwm: core: Zero-initialize the temp state
Message-ID: <20230226091752.wtnj7oqzmn6azahl@pengutronix.de>
References: <20230226013722.1802842-1-kamatam@amazon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5rbivgnxok4x6fcf"
Content-Disposition: inline
In-Reply-To: <20230226013722.1802842-1-kamatam@amazon.com>
Precedence: bulk


--5rbivgnxok4x6fcf
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sat, Feb 25, 2023 at 05:37:21PM -0800, Munehisa Kamata wrote:
> Zero-initialize the on-stack structure to avoid unexpected behaviors. Some
> drivers may not set or initialize all the values in pwm_state through the=
ir
> .get_state() callback and therefore some random values may remain there a=
nd
> be set into pwm->state eventually.
>=20
> This actually caused regression on ODROID-N2+ as reported in [1]; kernel
> fails to boot due to random panic or hang-up.
>=20
> [1] https://forum.odroid.com/viewtopic.php?f=3D177&t=3D46360

Looking through the report I wonder what actually made the machine fail
to boot. Doesn't this paper over a problem that should be fixed (also)
somewhere else?

Which driver is the one that the problem occur for?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--5rbivgnxok4x6fcf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmP7I70ACgkQwfwUeK3K
7AkSqQf+PQRB/iBxK2N2bbBFz6/yzLKrxeWeKcrWi5kCfwRHvJSMMmwGNUoq8HBp
mnNhvceIZDBrRCKcXosWgcUcf8jNFRlUqyLXf58yqIPJ5Tr7UGUBDYPmB6c/OasZ
CuGMiySQE36V32IvlJAUEIjQ7pnPSrwWg8fE8ZESo7L0hc1I7+XYVQPwJqklOZr3
OQkIlUKClBoe6Ak4C+dGbXAK8NVWHdRrmGbIWCNsILBM4uQopOXNA7ZWELf9f5m5
NcOCNkQNghhCMVEVEElcC0fDrV+ilwZJRNy5axMksQdDpPbPoiSs59bNDN9i3fj6
jn8SCuQbds+QDygig7ltfZB7w27MpA==
=MkIE
-----END PGP SIGNATURE-----

--5rbivgnxok4x6fcf--