Date:   Sun, 26 Feb 2023 13:01:36 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, paulb@nvidia.com, marcelo.leitner@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/sched: cls_api: Move call to
 tcf_exts_miss_cookie_base_destroy()
Message-ID: <Y/tKIKrR0ucIQ5mI@corigine.com>
References: <20230224-cls_api-wunused-function-v1-1-12c77986dc2d@kernel.org>
 <Y/oycX7fMP8yJAdd@corigine.com>
 <Y/p6b4rGiUqGHSsW@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/p6b4rGiUqGHSsW@dev-arch.thelio-3990X>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oK5fugVCO3ORhA4QljhYnmEAKgU+FJEYm1QQB0OdphSe1skaHXYjlXgqlsgg?=
 =?us-ascii?Q?h+zEmVGN75qk+lI9koKsgsSep5z8kAVvbM2Kzd6C0W6cbGy/2fQkREihDk6h?=
 =?us-ascii?Q?I4n/mYpIndMjPVwdtS/jWi7ZRd85vyZukSpeVAjan3dJJn1uvhXAIMrheWfJ?=
 =?us-ascii?Q?uVT9PshCNi4L/6f65cqU3hOBC31T3ITtsKBqwemOLSQQmd9aiCk/177HdA3o?=
 =?us-ascii?Q?bogSvcK9OV3sJrqa7PhIQCleEhfHNEIwA3tfRwiRLN/TZvdM4Qrq6vFIFbgi?=
 =?us-ascii?Q?jfcwL+MoRJ61lC4fVby6vf7VQfwRHo/jmI1vpqgaCS+JxrJ1Z6mDxLqDLDB4?=
 =?us-ascii?Q?9kd+LJiB12rxFg7EhjWC7/LyD6l7ZMPCFbQkgh83FsKgXqDc6mizXkbcHNS0?=
 =?us-ascii?Q?JCW9wjiXf4cPAWoTf8wz7g8IBhbzbq56eXTVdzccaTEMFcZp04j56zeYkliy?=
 =?us-ascii?Q?ch45vue4pKMJcEODJ346EbZVFALNHKMvoaMuGYvnDCLvqMwH1dxm8Y/zlSf1?=
 =?us-ascii?Q?H2uoKhiMHHMXPxH9LhnycqJSSNk73V5ZXd7Zol2I3sle7/OiQzs++8Is2Y7Q?=
 =?us-ascii?Q?qSY1tkxkKKchqokFYfDwS4GDu9oaV+musoEroQuCbUYdGpWBghV5WLgiV/fp?=
 =?us-ascii?Q?lLe45seYLNi8FUthiWiEVnzpJ6xIPfnU9ySqdpnJEOEu1ZvcMpW2LZYguS1r?=
 =?us-ascii?Q?eoFILQs5M5D6NS5sPHtoztgrSBPO3SDvF/lZO/+S8cAgGYs+8suX+U72eney?=
 =?us-ascii?Q?vgY2a8djI0DggeG8/Ag9YNPkXulVJL1xfz+zlSXCB5yr0uUpGqxwUzyTxNcn?=
 =?us-ascii?Q?g5OqBWiQtv+bcq1vdzb7jl+Ii2ro/8yqBGIdyLUya7sYEoVnHsj6LRk/IxvB?=
 =?us-ascii?Q?filqjjBqqQkyZgJO3XmXbhM41dJ11Q+JC7JCt3fG4eMbFCiI2ubTcfBaR8W6?=
 =?us-ascii?Q?O4He3TYcauY/BZ1Q644G3YRl43RerPR+uEdSIaVfYeenMprjKXtyXgbdXHGM?=
 =?us-ascii?Q?NGgKowa/Z2ieDVzU9WcVKk1/5ZAU2BG8z6l2bHiWwiReQBJVa9ZWEdHIlLni?=
 =?us-ascii?Q?U7DkjkpNTf3jxtXTIkf7F8FU+ziwZb7qREGmeg11SYfbDHvl40cg4VVuYNhU?=
 =?us-ascii?Q?XwaqGmJLWkVw84lKo8BO2Rh0xYb9WkOEOSCynS+woKnnp1eFHCHgr+uwNliq?=
 =?us-ascii?Q?XS2DDj1y4rs3kNfF4xKO2ofgD3N1jpokqbgVlItw7t69WS3YpOMkWMLJPfV2?=
 =?us-ascii?Q?f4kByQcHNYhRX8EBR4FzAe3iC0vNIAbltbDYuaJEX8tMbG7ruBvZyTwkP3Tv?=
 =?us-ascii?Q?M5uHoM/rFrZ2ukQMEt8LfUB8kRBwFcooj7IjxInIuBRq79m7g2CdSpQop4l+?=
 =?us-ascii?Q?3i1jLgqSGuiLnVBr7qEPhljTtLdsgQYEycw+MiJp9Oz3Fk4y6j3ptAPGnbxi?=
 =?us-ascii?Q?3fNHIIeCkyLFpmYJgxam7AlwaV+Z/wFRyjPqlyHABbHDYcLl3imMsiqqeaAg?=
 =?us-ascii?Q?W9w8Tcs42pxKBNcR3OVgGseeYK5YfBgHIqXjPPGDYWeonvXEpFbcjT+FBpKc?=
 =?us-ascii?Q?ZcDyDDxbZ+D9NOhhJR/QAB426li46pRJc0xQ97TDyLame2UgUkO9z6+fowsU?=
 =?us-ascii?Q?psLWlQmbNuVnKh3kG2FJ4DuQZRl/aX3vYHBi7dhr/MZaa6jESOmCJBu6bMdL?=
 =?us-ascii?Q?Ohi4tg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4da836b9-eaad-467f-23fb-08db17f13ade
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2023 12:01:44.8375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ExpNiev3wJ1QwUwoLxCchW5ObGZsJB5HJMpkS3qveh4FWHcaATD/uFgdGVe+40gjYSGmhWIUgRe22gsvxMXZMo4o8bDy3DIgm8Rrqyc8WOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB6020
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 25, 2023 at 02:15:27PM -0700, Nathan Chancellor wrote:
> On Sat, Feb 25, 2023 at 05:08:17PM +0100, Simon Horman wrote:
> > On Fri, Feb 24, 2023 at 11:18:49AM -0700, Nathan Chancellor wrote:
> > > When CONFIG_NET_CLS_ACT is disabled:
> > > 
> > >   ../net/sched/cls_api.c:141:13: warning: 'tcf_exts_miss_cookie_base_destroy' defined but not used [-Wunused-function]
> > >     141 | static void tcf_exts_miss_cookie_base_destroy(struct tcf_exts *exts)
> > >         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > Due to the way the code is structured, it is possible for a definition
> > > of tcf_exts_miss_cookie_base_destroy() to be present without actually
> > > being used. Its single callsite is in an '#ifdef CONFIG_NET_CLS_ACT'
> > > block but a definition will always be present in the file. The version
> > > of tcf_exts_miss_cookie_base_destroy() that actually does something
> > > depends on CONFIG_NET_TC_SKB_EXT, so the stub function is used in both
> > > CONFIG_NET_CLS_ACT=n and CONFIG_NET_CLS_ACT=y + CONFIG_NET_TC_SKB_EXT=n
> > > configurations.
> > > 
> > > Move the call to tcf_exts_miss_cookie_base_destroy() in
> > > tcf_exts_destroy() out of the '#ifdef CONFIG_NET_CLS_ACT', so that it
> > > always appears used to the compiler, while not changing any behavior
> > > with any of the various configuration combinations.
> > > 
> > > Fixes: 80cd22c35c90 ("net/sched: cls_api: Support hardware miss to tc action")
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > 
> > Thanks Nathan,
> > 
> > I think the #ifdefs in this file could do with some work.
> 
> Yes, it is definitely an eye sore. I thought about cleaning it up but it
> felt like net-next material to me, plus I have no other interest in this
> code other than making the warning in my builds go away, if I am being
> honest :)

Yes, of course (x2) :)

> > But as a fix this looks good to me.
> > 
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> 
> Thanks for the quick review!
> 
> Cheers,
> Nathan
>