Date:   Sun, 26 Feb 2023 14:33:07 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Emil Renner Berthing <emil.renner.berthing@canonical.com>,
        Xingyu Wu <xingyu.wu@starfivetech.com>
CC:     linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
        linux-watchdog@vger.kernel.org,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Samin Guo <samin.guo@starfivetech.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver
User-Agent: K-9 Mail for Android
In-Reply-To: <CAJM55Z823iqUqD8enM0qJ_MA3Tw94Mn0mq71fbLT1Qjo2s2J3g@mail.gmail.com>
References: <20230220081926.267695-1-xingyu.wu@starfivetech.com> <20230220081926.267695-3-xingyu.wu@starfivetech.com> <CAJM55Z823iqUqD8enM0qJ_MA3Tw94Mn0mq71fbLT1Qjo2s2J3g@mail.gmail.com>
Message-ID: <CA6686A1-2336-442F-8C7B-7D8EFEEE1940@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 26 February 2023 14:14:25 GMT, Emil Renner Berthing <emil=2Erenner=2Ebe=
rthing@canonical=2Ecom> wrote:
>On Mon, 20 Feb 2023 at 09:21, Xingyu Wu <xingyu=2Ewu@starfivetech=2Ecom> =
wrote:
>>
>> Add watchdog driver for the StarFive JH7110 SoC=2E
>>
>> Signed-off-by: Xingyu Wu <xingyu=2Ewu@starfivetech=2Ecom>
>> ---
>>  MAINTAINERS                     |   7 +
>>  drivers/watchdog/Kconfig        |   9 +
>>  drivers/watchdog/Makefile       |   2 +
>>  drivers/watchdog/starfive-wdt=2Ec | 651 ++++++++++++++++++++++++++++++=
++
>>  4 files changed, 669 insertions(+)
>>  create mode 100644 drivers/watchdog/starfive-wdt=2Ec
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 135d93368d36=2E=2E6cbcf08fa76a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19933,6 +19933,13 @@ F:     Documentation/devicetree/bindings/reset=
/starfive,jh7100-reset=2Eyaml
>>  F:     drivers/reset/reset-starfive-jh7100=2Ec
>>  F:     include/dt-bindings/reset/starfive-jh7100=2Eh
>>
>> +STARFIVE JH7110 WATCHDOG DRIVER
>> +M:     Xingyu Wu <xingyu=2Ewu@starfivetech=2Ecom>
>> +M:     Samin Guo <samin=2Eguo@starfivetech=2Ecom>
>> +S:     Supported
>> +F:     Documentation/devicetree/bindings/watchdog/starfive*
>> +F:     drivers/watchdog/starfive-wdt=2Ec
>> +
>>  STATIC BRANCH/CALL
>>  M:     Peter Zijlstra <peterz@infradead=2Eorg>
>>  M:     Josh Poimboeuf <jpoimboe@kernel=2Eorg>
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 0bc40b763b06=2E=2E4608eb5c9501 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -2089,6 +2089,15 @@ config UML_WATCHDOG
>>         tristate "UML watchdog"
>>         depends on UML || COMPILE_TEST
>>
>> +config STARFIVE_WATCHDOG
>> +       tristate "StarFive Watchdog support"
>> +       depends on RISCV
>
>Let's do like the pinctrl and clock drivers and
>
>    depends SOC_STARFIVE || COMPILE_TEST

Or better yet, rebase on 6=2E3-rc1, and use ARCH_STARFIVE and save me a co=
nversion!

Thanks,
Conor=2E