Date:   Sun, 26 Feb 2023 16:52:38 +0100 (CET)
From:   Richard Weinberger <richard@nod.at>
To:     Wang YanQing <udknight@gmail.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <949898059.176653.1677426758468.JavaMail.zimbra@nod.at>
In-Reply-To: <20230226141406.GA32048@udknight>
References: <20230217165442.GA28288@udknight> <20230226141406.GA32048@udknight>
Subject: Re: [PATCH] mtd: ubi: eba.c: fix return value overwrite issue in
 try_write_vid_and_data()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: eba.c: fix return value overwrite issue in try_write_vid_and_data()
Thread-Index: iX6BMGP8zHgA8cIv1+NVBi+UxLxKBQ==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Wang YanQing" <udknight@gmail.com>
> An: "Miquel Raynal" <miquel.raynal@bootlin.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "richard" <richard@nod.at>,
> "Vignesh Raghavendra" <vigneshr@ti.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Sonntag, 26. Februar 2023 15:14:06
> Betreff: Re: [PATCH] mtd: ubi: eba.c: fix return value overwrite issue in try_write_vid_and_data()

> On Sat, Feb 18, 2023 at 12:58:08AM +0800, Wang YanQing wrote:
>> The commit 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
>> adds helper function, try_write_vid_and_data(), to simplify the code, but this
>> helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
>> or the ubi_io_write_data() return error number (-EIO, etc), because the return
>> value of ubi_wl_put_peb() will overwrite the original return value.
>> 
>> This issue will cause unexpected data loss issue, because the caller of this
>> function and UBIFS willn't know the data is lost.
>> 
>> Fixes: 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
>> 
>> Signed-off-by: Wang YanQing <udknight@gmail.com>
> 
> Hi! Miquel Raynal
> 
> What is the status about this patch?

We're in the middle of the merge window. It will be applied to the fixes
branch after rc1.

Thanks,
//richard