MIME-Version: 1.0
References: <20230219114553.288057-1-frank@oltmanns.dev> <20230219114553.288057-2-frank@oltmanns.dev>
In-Reply-To: <20230219114553.288057-2-frank@oltmanns.dev>
From:   Slade Watkins <srw@sladewatkins.net>
Date:   Sun, 26 Feb 2023 11:54:57 -0500
Message-ID: <CA+pv=HPY1HCDJ=sHeg_S7ZusS1RqiYvGOUf2bPVZK7Rq_EfHUg@mail.gmail.com>
Subject: Re: [PATCH 1/1] drm/panel: st7703: Fix vertical refresh rate of XBD599
To:     frank@oltmanns.dev
Cc:     =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>,
        Purism Kernel Team <kernel@puri.sm>,
        Ondrej Jirman <megous@megous.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Feb 19, 2023 at 6:46=E2=80=AFAM Frank Oltmanns <frank@oltmanns.dev>=
 wrote:
>
> Fix the XBD599 panel's slight visual stutter by correcting the pixel
> clock speed so that the panel's 60Hz vertical refresh rate is met.
>
> Set the clock speed using the underlying formula instead of a magic
> number. To have a consistent procedure for both panels, set the JH057N
> panel's clock also as a formula.
> ---

Hi Frank,
Just wanted to let you know that this appears to be missing your Signed-off=
-by:.

Thanks,
-- Slade

>  drivers/gpu/drm/panel/panel-sitronix-st7703.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/=
drm/panel/panel-sitronix-st7703.c
> index 6747ca237ced..cd7d631f7573 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -139,7 +139,7 @@ static const struct drm_display_mode jh057n00900_mode=
 =3D {
>         .vsync_start =3D 1440 + 20,
>         .vsync_end   =3D 1440 + 20 + 4,
>         .vtotal      =3D 1440 + 20 + 4 + 12,
> -       .clock       =3D 75276,
> +       .clock       =3D (720 + 90 + 20 + 20) * (1440 + 20 + 4 + 12) * 60=
 / 1000,
>         .flags       =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
>         .width_mm    =3D 65,
>         .height_mm   =3D 130,
> @@ -324,7 +324,7 @@ static const struct drm_display_mode xbd599_mode =3D =
{
>         .vsync_start =3D 1440 + 18,
>         .vsync_end   =3D 1440 + 18 + 10,
>         .vtotal      =3D 1440 + 18 + 10 + 17,
> -       .clock       =3D 69000,
> +       .clock       =3D (720 + 40 + 40 + 40) * (1440 + 18 + 10 + 17) * 6=
0 / 1000,
>         .flags       =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
>         .width_mm    =3D 68,
>         .height_mm   =3D 136,
> --
> 2.39.1
>