Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E506C64ED6 for ; Sun, 26 Feb 2023 23:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbjBZXvn (ORCPT ); Sun, 26 Feb 2023 18:51:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjBZXvk (ORCPT ); Sun, 26 Feb 2023 18:51:40 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B73C869C for ; Sun, 26 Feb 2023 15:51:38 -0800 (PST) Received: from [192.168.2.206] (109-252-117-89.nat.spd-mgts.ru [109.252.117.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9EBC06602DCD; Sun, 26 Feb 2023 23:51:36 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677455497; bh=j42W91BDA/HzPgVKrySGK5CNdsmZZvukLN7V+IbXt3c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Pgopsf0TFxrJjOQ+I+Dl166lURpTZha1/EBXUIt8mnCUcOL1kvRaxCHiyzMariZDs AZ+/20pmGsNRzu6wWpdS3Pnm5DMf2FdVafWleLGAWUjGCj47Y1GnK0q38VavwWAsvm c9aGkOP4MtFzojEH4VtoQWzN7sTZI3JY9Jf3BL6/9Lg/DNO314ffYJsi1iA9iEx9Jq nK9oh+ctmVPqAJWeesdaMJOuUVtEiMHbEDEtixVq1Tlue0i1eNY8xG+DaTFATG/L3E 2kzvaTb7UoAF0ZPO0XfdM1GVNvedI0QHpA2lQQotnI1mGQLc0McepyLl8Bz5PiYZg+ j2yful4OGUDVQ== Message-ID: <74ae7a91-1dd3-06f1-2199-5c1a18ab7d50@collabora.com> Date: Mon, 27 Feb 2023 02:51:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1] drm/shmem-helper: Remove another errant put in error path Content-Language: en-US To: Rob Clark Cc: Thomas Zimmermann , Daniel Vetter , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230108211311.3950107-1-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/16/23 18:35, Rob Clark wrote: > On Sun, Jan 8, 2023 at 1:13 PM Dmitry Osipenko > wrote: >> >> drm_gem_shmem_mmap() doesn't own reference in error code path, resulting >> in the dma-buf shmem GEM object getting prematurely freed leading to a >> later use-after-free. >> >> Fixes: f49a51bfdc8e ("drm/shme-helpers: Fix dma_buf_mmap forwarding bug") >> Cc: stable@vger.kernel.org >> Signed-off-by: Dmitry Osipenko > > Reviewed-by: Rob Clark Applied to misc-fixes -- Best regards, Dmitry