Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF1FC64ED8 for ; Mon, 27 Feb 2023 04:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbjB0Ee6 (ORCPT ); Sun, 26 Feb 2023 23:34:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjB0Ee4 (ORCPT ); Sun, 26 Feb 2023 23:34:56 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7FB15554 for ; Sun, 26 Feb 2023 20:34:54 -0800 (PST) Received: from [192.168.2.206] (109-252-117-89.nat.spd-mgts.ru [109.252.117.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id B9008660217D; Mon, 27 Feb 2023 04:34:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677472493; bh=Q+RRLIC4HI40FUSzS41A43b5og4HGlLpqG8USccRVGk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YoRu+YEKHI5r3oclywm0nao1CdRIfIXGx1QyJairfK58hFa9P0GJ+MM83ZefIawwx PwXUM063ItFAVuaTq0Y9VdF+beKRimcNhEWBOm4Qqrd+11GcGyO9jrSO5xIdv9sIIK jB5Hg3k4Ti0+yTCsv4Ha64yr3K4Gak7vOxFnOecQ5KB8z0an5syiCL0MEc9xnF3Kkg Mbw49X5mShtKFNA1y8ZngHczwQGUmkETv4PXJctQh2/O2oTh2e8i4TYtLLysP7NeUy R66M1BU2+W7BuXMiCLT6mh8SrEMsM9rvUzSpZ3reiSMARzKBvdcqfUOgdV3Yd1JYIH gj6Cd5L09uOrg== Message-ID: Date: Mon, 27 Feb 2023 07:34:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v10 08/11] drm/shmem-helper: Add memory shrinker Content-Language: en-US To: Thomas Zimmermann , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gustavo Padovan , Daniel Stone , Maarten Lankhorst , Maxime Ripard , Rob Clark , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Qiang Yu , Steven Price , Alyssa Rosenzweig , Rob Herring , Sean Paul , Dmitry Baryshkov , Abhinav Kumar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org References: <20230108210445.3948344-1-dmitry.osipenko@collabora.com> <20230108210445.3948344-9-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/23 16:19, Thomas Zimmermann wrote: >> +/** >> + * drm_gem_shmem_swap_in() - Moves shmem GEM back to memory and enables >> + *                           hardware access to the memory. > > Do we have a better name than _swap_in()? I suggest > drm_gem_shmem_unevict(), which suggest that it's the inverse to _evict(). The canonical naming scheme used by TTM and other DRM drivers is _swapin(), without the underscore. I'll use that variant in v11 for the naming consistency with the rest of DRM code. -- Best regards, Dmitry