Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6825C64ED6 for ; Mon, 27 Feb 2023 05:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbjB0FxJ (ORCPT ); Mon, 27 Feb 2023 00:53:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjB0FxG (ORCPT ); Mon, 27 Feb 2023 00:53:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF2FD535 for ; Sun, 26 Feb 2023 21:52:58 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWWRK-0008Db-1o; Mon, 27 Feb 2023 06:52:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWWRF-00059C-Aw; Mon, 27 Feb 2023 06:52:41 +0100 Date: Mon, 27 Feb 2023 06:52:41 +0100 From: Oleksij Rempel To: Mark Brown Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Message-ID: <20230227055241.GC8437@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> <20230211074113.2782508-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote: > > Add replacement for phy_ethtool_get/set_eee() functions. > > > > Current phy_ethtool_get/set_eee() implementation is great and it is > > possible to make it even better: > > - this functionality is for devices implementing parts of IEEE 802.3 > > specification beyond Clause 22. The better place for this code is > > phy-c45.c > > Currently mainline is failing to bring up networking on the Libre > Computer AML-S905X-CC, with a bisect pointing at this commit, > 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it > seems to be in roughly the right place). I've not dug into what's going > on more than running the bisect yet. Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |