Date:   Mon, 27 Feb 2023 10:23:11 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Kang Chen <void0red@gmail.com>
Cc:     paskripkin@gmail.com, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: add a null check of kzalloc in
 go_add_group_info_attr
Message-ID: <Y/xaXw9LAOizJEBL@kadam>
References: <20230226132500.3933232-1-void0red@gmail.com>
 <Y/w16PI4klfJaeXA@kadam>
 <CANE+tVpqZusCq4EXi7UV+jY0XBG+9x6UWh_JGCWKs3pZRMFBXA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANE+tVpqZusCq4EXi7UV+jY0XBG+9x6UWh_JGCWKs3pZRMFBXA@mail.gmail.com>
Precedence: bulk

On Mon, Feb 27, 2023 at 03:11:21PM +0800, Kang Chen wrote:
> Hi, Dan,
> 
> Thanks for your review.
> I noticed there is no error handling in the origin design (this call chain).
> go_add_group_info_attr returns a len-like value indicating the length
> of pbuf.
> I don't think throwing an error to the caller is a good idea, the caller
> doesn't seem to care about it.
> So inserting a netdev_dbg or pr_debug here might be enough.
> Do you have a better idea?
> 

The bug is real, yes.  But you have your static checker which can detect
it and I also have an unpublished static checker test which detects this
bug.

drivers/staging/r8188eu/core/rtw_p2p.c:106 go_add_group_info_attr() warn: 'pdata_attr' was never checked for NULL

If we just hide the bug enough for so that the static checker cannot
find the bug then we're taking a step backward.  When this driver is
ready to leave staging then normally I review every static checker
warning.  But if we hide the warning then it will never be fixed.

regards,
dan carpenter