Message-ID: <8e5f9bfa-d612-cd43-d722-d04c40938c62@linaro.org>
Date:   Mon, 27 Feb 2023 09:15:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
From:   neil.armstrong@linaro.org
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH v1 0/3] Meson A1 32-bit support
To:     Alexey Romanov <avromanov@sberdevices.ru>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        linus.walleij@linaro.org
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@sberdevices.ru
References: <20230222115020.55867-1-avromanov@sberdevices.ru>
Content-Language: en-US
Organization: Linaro Developer Services
In-Reply-To: <20230222115020.55867-1-avromanov@sberdevices.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/02/2023 12:50, Alexey Romanov wrote:
> Hello!
> 
> This patchset adds support for 32-bit Meson A1 board.

Hi Alexev,

I'm aware Amlogic also runs their kernel as 32bit to gain a few kbytes
of memory, but those processors are ARMv8 and the arm64 arch code
has been designed for those CPUs.

So far I didn't find a single good reason to add 32bit support for
ARMv8 Amlogic based SoCs, if you have a solid reason please share.

And as Krzysztof stated, the support is incomplete and cannot work
without a dts file.

Neil

> We describe device tree with following components:
> CPU, GIC, IRQ, Timer, UART, PIN controller.
> It's capable of booting up into the serial console.
> 
> We have tested this DTS and used drivers at our
> 32-bit Meson A1 board and it works correctly.
> 
> Alexey Romanov (3):
>    meson: pinctrl: use CONFIG_PINCTRL_A1 with CONFIG_ARM
>    firmware: meson: use CONFIG_MESON_SM with CONFIG_ARM
>    arch/arm: dts: introduce meson-a1 device tree
> 
>   arch/arm/boot/dts/meson-a1.dtsi | 151 ++++++++++++++++++++++++++++++++
>   drivers/firmware/meson/Kconfig  |   2 +-
>   drivers/pinctrl/meson/Kconfig   |   2 +-
>   3 files changed, 153 insertions(+), 2 deletions(-)
>   create mode 100644 arch/arm/boot/dts/meson-a1.dtsi
>