MIME-Version: 1.0
References: <cover.1677063656.git.viresh.kumar@linaro.org> <CABymUCMhoKoFHy8K6-ohrcAbyTpDe0Hig3oUM_wH4Db0-9yx+g@mail.gmail.com>
 <20230224021713.stpcykx2tjkjwyti@vireshk-i7> <Y/hyf+/EqEeTu436@niej-dt-7B47> <20230227042349.3p2ijo6s6yyqc267@vireshk-i7>
In-Reply-To: <20230227042349.3p2ijo6s6yyqc267@vireshk-i7>
From:   Jun Nie <jun.nie@linaro.org>
Date:   Mon, 27 Feb 2023 17:21:56 +0800
Message-ID: <CABymUCNBkr_65JHNVfbUGjxs6rhnj=eUyZ+5j6VtiDwqzLYtcA@mail.gmail.com>
Subject: Re: [PATCH 0/3] OPP: Simplify set_required_opp handling
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     cw00.choi@samsung.com, Nishanth Menon <nm@ti.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Viresh Kumar <vireshk@kernel.org>, linux-pm@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Viresh Kumar <viresh.kumar@linaro.org> =E4=BA=8E2023=E5=B9=B42=E6=9C=8827=
=E6=97=A5=E5=91=A8=E4=B8=80 12:23=E5=86=99=E9=81=93=EF=BC=9A
>
> On 24-02-23, 16:17, Jun Nie wrote:
> > For the opp lib, this is right direction. We still need to find a metho=
d to
> > pass devfreq device node to opp lib, just genpd_virt_devs for power dom=
ain.
>
> I am not really sure I understood it all. What is "device node" ? DT node=
 or
> struct device ? What exactly do you need ?

Sorry for not expressing it accurately. I should say devfreq devices
pointers, just
devfreq_virt_devs vs genpd_virt_devs. Then you know why I add devfreq-devs
dts nodes below.

>
> > But I am not clear below is the right way yet and this also involves wi=
der
> > changes. Or the opp's owner, devfreq device can be referred via opp lib=
?
> > If so, we do not need to add devfreq-devs to cpu node at all.
> >
> >               cpu1: cpu@101 {
> >                       compatible =3D "arm,cortex-a53";
> >                       device_type =3D "cpu";
> >                       power-domains =3D <&cpr>;
> >                       power-domain-names =3D "cpr";
> >                       devfreq-devs =3D <&cci>;
> >                       devfreq-names =3D "cci";
>
> Why do you need these ?
>
> >                       operating-points-v2 =3D <&cluster1_opp_table>;
> >               };
> >
> >               opp-200000000 {
> >                       opp-hz =3D /bits/ 64 <200000000>;
> >                       required-opps =3D <&cpr_opp3>, <&cci_opp1>;
>
> This looks fine though.
>
> >               };
>
> --
> viresh