Message-ID: <3a9269bf-0d1c-59b4-f80f-afbbdf9c45b4@amd.com>
Date:   Mon, 27 Feb 2023 15:42:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH V2 2/3] sched/numa: Enhance vma scanning logic
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>, rppt@kernel.org,
        Bharata B Rao <bharata@amd.com>,
        Disha Talreja <dishaa.talreja@amd.com>
References: <cover.1675159422.git.raghavendra.kt@amd.com>
 <5f0872657ddb164aa047a2231f8dc1086fe6adf6.1675159422.git.raghavendra.kt@amd.com>
 <Y9zs5A/T1WQpJTuM@hirez.programming.kicks-ass.net>
 <048964e8-179f-de7b-1190-831779d9911f@amd.com>
 <ccba1a65-fe4f-89d5-a32b-2efba30a1350@amd.com>
 <c730dee0-a711-8a8e-3eb1-1bfdd21e6add@amd.com>
 <Y/yAmDj6tQVfOdqK@hirez.programming.kicks-ass.net>
From:   Raghavendra K T <raghavendra.kt@amd.com>
In-Reply-To: <Y/yAmDj6tQVfOdqK@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amZqNXIzSWlwYkRPeVhYaXVDNUszclFJRFFWdTlCWVJzeWFScVE1ZUlrSHVx?=
 =?utf-8?B?bFl3eFB3QUcvcVdiVXEvOU9BRmVNY3ZLUzZCajFYZlpDaWpMSEJhaFF1Q25W?=
 =?utf-8?B?enhvc2QvelBxaEUzaDJRMEFRNzltUVBLb3dONk9qczRDMkpDNnNJeVdjd3pI?=
 =?utf-8?B?Z21ya0plajNCTldURStFTTlMSnIrVGl1VVdMbkZGSitBb0xGU2I1dWJ2Qmp0?=
 =?utf-8?B?c3NYMGlQZUxVQmZ5cHRnUlpkaElIWHpCR3VIUFBFUUJ3Rk5Fbm1GQko5NXRa?=
 =?utf-8?B?Z044anBHREJ5c1A1b0ZQaGRCeFRzOGEyeDVnNHkxaDJCY3pPUUcvTjI3aXRs?=
 =?utf-8?B?aFFxTE5HSW5lYWdMenVzc3c0M0dlTEVTbkN3RC9LQXEvQzEyR1pRQ3kydWtV?=
 =?utf-8?B?MjNNQm81UzRXOTNNWTFDZlgxb3l1LzhYSDk3dk5ndFMxU25ya2NlT0grenk0?=
 =?utf-8?B?d0dyOGRkSEFwbEZnOXNxK3VqdXF1WCtya1JCTDRWc25rUTlwV2VyaVBLemJV?=
 =?utf-8?B?anhDTzJhU1FKWFpKcWljY2VzNENEclJXd1FsMS9nL0xadTJ6ZGEwcHpDWDd1?=
 =?utf-8?B?QzVweWdYTkIzU2RVV0pVZWw5UGYxUDZLY3JBVGMvOHFiMk1hRDdEcmVwaXpv?=
 =?utf-8?B?VjViWEFUeVNJSC9pd1dPN0NMcDI5YXZLYVlFVWF1R3JidXJjVGtraU5TZU5m?=
 =?utf-8?B?OTBtcGd2eTVMdCtLcU1rUmhDT0RkZ0RaUWVPMUJlamJsRUIrZG1NV0llRlBE?=
 =?utf-8?B?Y2pyTVY0RlhzTndvSFMzNnJvZjFkSW5XaVk5N3JmYi9uNzJPNHNpZFdxbkg1?=
 =?utf-8?B?b2lkVmRhQUhGNGYweXJtczdVL2laQXhWSTVaU084UzZRTGVmOVU3N2xsRjRt?=
 =?utf-8?B?L2lXalBZZ2oxQ1pydWZNU0NDbDNEaVFDVVV2blkyQnRsSFlzSDBXSFkzd2Jz?=
 =?utf-8?B?eFFTbHhuME1qaHNzczgxTEg5ZVRHYkJSUmhBRkRSMFNtRUZvMjhrVzZrZVcx?=
 =?utf-8?B?YXprQ0JrTUpJaVpRY1p5Nno2bXZDY1FQVkFxVmVKbFRkMEJNRXJteDYzSU5E?=
 =?utf-8?B?SzhZTFRFTzJnYjFXa05aM2cwbXltbGRoLy9IekQ2dlVzc2pFRXRyK1hKOUNs?=
 =?utf-8?B?bEdLOWVJTHJLdi9oRFRzYjdNVmp3YnlxZHZrT3dhVFBYZ3Nya3ZCYnU0eVRN?=
 =?utf-8?B?M2l5Wmp0YnpnWnFPaUd5U0hDdmtYbHFtL0VvVUVOaWMrOTdXbWl4Z2tVUlZt?=
 =?utf-8?B?Ulp1TjJBbkJINzVja1pzSVNpQ3A1eEFRNUtLRS9UM0dGc0tiWmpHaTJtcE5s?=
 =?utf-8?B?ZlplaHJocEN0Nis1bUZFVHpZUnNIOFZ2L3NyLzgvQVhFQW9MS1cvMzAzNnJ2?=
 =?utf-8?B?YXAvamY3RkJGUFlQNUhyVzdEVzk4MWo5WHU5aWUrckY1NWRRVk9oSUlTQjdE?=
 =?utf-8?B?MTh0dWFYaThZTjVtNVROa1cvbFk1b0tpNXVRRG16NEJCMEJlcmlLbXRqaGRn?=
 =?utf-8?B?bWNwZENGemJ2dTRXbUNjVlFtTThoYnMxU3kzbVpVellRSHRqVlZzaUVCZ2g2?=
 =?utf-8?B?azZkTnI5cDRTVVk0bmdQZHk4aWJBZWZGZzlZbllIQnhybTUyZ01zM1gySUlC?=
 =?utf-8?B?NXhYM1hBeEEyREVyOFpJOHpXdWtLTzFObS9sL0l6TGJ6V2dOWTJQMEpkb1RI?=
 =?utf-8?B?US9pRHVRV2ZNekVON0RiTnVCSUEwOXYvYU1nZlRxczZzYmEyQVhnRXlwd2Ix?=
 =?utf-8?B?SkpVN1l4eWZ4MzVjNGlKWFpjZkY4ZSsvQkF4T2VMa0tXeEVhQnZqaXJsMlg5?=
 =?utf-8?B?MjhGRTJGQjZTeUZ2b2FNYVNBaU4vaE11aktjOHd4VWlnVW92OWVnUlloQ3Vu?=
 =?utf-8?B?bUhvSTZqL215RkE5bGt6NTlaSGIwSkNzU3YrSlJCb0F1SnJUc1RqVzRWcU9q?=
 =?utf-8?B?ZWE0SmtLQ09jbGlZT0daZmtJSmg1b2tZeEhFVHByNmdxL3BtdHp4YzZEMXFo?=
 =?utf-8?B?Y3o1dy9Yb2s1K2FENzZORmpaV1BqVnFjOEtLTnVYRFhHZUNKOHgrOWgrbzFD?=
 =?utf-8?B?TEV5U2VocVZsLy9aTmtvN1p4WDJoZ2o1UU9UdFNwQ2hXL0R1cW1iSmNBaTF5?=
 =?utf-8?Q?Jy1iQ55gaPh+iTccEC4xuSpWm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef7b2e99-699d-45c7-6421-08db18ab3340
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3008.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:12:58.5764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fv+ziwCj/EVn8OiMarMcVr5mzRErO3Hp4WH0NsaX99a7La2mdfsEkHBVNgXEOzRXz5WAiDeZ6YvSEzcIkph+CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7476
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/27/2023 3:36 PM, Peter Zijlstra wrote:
> On Mon, Feb 27, 2023 at 12:10:41PM +0530, Raghavendra K T wrote:
>> In summary: I do see that access to VMAs from disjoint sets is not fully
>>   fair, But on the other hand it is not very bad too. There is definitely
>> some scope or possibility to explore/improve fairness in this area
>> further.
> 
> Ok, might be good to summarize some of this in a comment near here, so
> that readers are aware of the caveat of this code.
> 

Sure will do.

>> PS: I have also tested above applying V3 patch (which incorporates your
>> suggestions), have not seen much deviation in observation with patch.
> 
> I'll see if I can find it in this dumpester fire I call inbox :-)

Sorry I wasn't clear there.. Still in inbox and am about to post.. It
was a heads up.