From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>
Subject: RE: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Topic: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Thread-Index: AQHZSG4K8+wSVKmZRkimkrAiwHDmq67eTmSAgAAAM/CAABMSgIAENYWg
Date:   Mon, 27 Feb 2023 10:36:18 +0000
Message-ID: <DM4PR12MB576994B630B7D8F43BD21F73C3AF9@DM4PR12MB5769.namprd12.prod.outlook.com>
References: <20230224163513.27290-1-kyarlagadda@nvidia.com>
 <Y/jqCRAenwbqc1Uu@sirena.org.uk>
 <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
 <Y/j6MxmOkZj/TKej@sirena.org.uk>
In-Reply-To: <Y/j6MxmOkZj/TKej@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?txHpz4MUkgkKbKw3G9VtiwYTOq8cYJuI61oyL55kxt/KfTUOlxbZ0qQ1fcHS?=
 =?us-ascii?Q?E80/UG9cH5O+dYvEzzZvN6b6boHIVblCHcD4BEJTSiNu+JuuvrzD/F0zxsDv?=
 =?us-ascii?Q?detNngmR3LjKapJXZo00x1OcrhK7Ubju8i/96hX5CS6DiU7rEbDIHtTQ29pC?=
 =?us-ascii?Q?PMF0/MSnlKYTVJNXhVg1HHVavFZyk7wVhLSZt5+CK4Uqp/m4Qha9Z8Cglnc/?=
 =?us-ascii?Q?3r8+fauvPDs9PiN8q0qTDQN+cLwncpGaXFE22MNz67aYU0D2+FD0MsGfX3Mp?=
 =?us-ascii?Q?0/QISUnFC1coBgj+gv6Y2Cu9Tu/Qm1xnrQQZjAPV4wT562OV0CM0uqwJMwSX?=
 =?us-ascii?Q?xr3SKPExpDHtc89AemUC+KdYbLfZsGKc5tRBMSOAanNv4teXzJudxquttMf8?=
 =?us-ascii?Q?JQsm08OttUWaSrI0lfefiaPu2kIhFdzrPdsDpVhrIASxGMZDpBD2khLuvKz4?=
 =?us-ascii?Q?bpa9kS44wx/QWxo+qpGihMGWMcRGuWMlz1aXyB/OV0A9rnYWx/r4LC7Aqubk?=
 =?us-ascii?Q?iweMwsExcstZk7M1GyQbBwxQWMmYeIcUZYL1e+zigc7nTIcd1QLp3l9kjyhx?=
 =?us-ascii?Q?WGdgrWZqkj1P0a4h23LSH3EvUuwxcAj6W5SdwBa+A9wOtBB5shmTfG3kQ5/s?=
 =?us-ascii?Q?EJrY9+Vr0wzBcDsUkALq5Z0D58LL5FZY6H+zcs23kJSWR9ODh9wZEWgCHrP6?=
 =?us-ascii?Q?G3eEgOottNjL3OKHl1OgBLNKECpHFweCJv8fJVCIt3i65MDpXBNSuOpKRlTa?=
 =?us-ascii?Q?fOpZowg5FlJMfmYAkK/WmjfxZrbhnHrGmNUHEaLi6d35Rc7xepy2UQDyPwbk?=
 =?us-ascii?Q?FInesRCMxZem4g9dgOJy0aXUca0exvBwT6JLzakMQpVMZG0Y8CmEoVH93OT6?=
 =?us-ascii?Q?asC6X8ryc/1hUD8tZYVF3mIVbtLzj0nmKxw5UU02fNZ/AIny/j6vztzjzDDN?=
 =?us-ascii?Q?nfkEzGT+u8jp2Jp+rf93CKPAhYzjS3PBM1lK9t9zrqG9IOCe8CX/HePoy0R3?=
 =?us-ascii?Q?9QM0c2dmiajjGXQJyW8R/oWfCKxqeSmsMJCCUAkddObD+0OY4lq9e6beAv1A?=
 =?us-ascii?Q?nQoo/a+lfVehMXaUEB/u3RhxgG6kVxmcwJGIZ/dDVDA0q+G+oxmPu/bY+rVe?=
 =?us-ascii?Q?6nJw/OWIt8F6+f0Q/cX8xkthFZOFfLw4ySfyPWLjLExKPkZEvhFlinZjLVN/?=
 =?us-ascii?Q?vI6/2YI8mY2rD+jBrM3WyB5C9r0N59jGXHzG0lpLxuaXU+Jhc4rMcWpQR8Gx?=
 =?us-ascii?Q?SrBJd1shSLCKwYe7f3VIOdpMn7e8PYp926GG3X+Re+UE/D0G5Gt2SAM3Bwky?=
 =?us-ascii?Q?l8ksU9saIrdpxaah0cpO/VN0rqj7bj7RBlp9bOo0eoxBKz9fwTgg8melI2Xp?=
 =?us-ascii?Q?TIdFp8XpDnCA0xMybWFLvkFWjcVQQj6D34xe3Ka8rN4yVsayc/RMR1Z+Hrmr?=
 =?us-ascii?Q?oYtoNOO/USK62ACWWZvVTqKRViBPKeQI8K4LHF890hRmBiI+pO+z4I2X5F1Q?=
 =?us-ascii?Q?gG9d4cuLCyTaPdzZ0ck+0ffcIOD2Dvpn6BYdpHfts6ELQNXtDEb4IwFmwjXz?=
 =?us-ascii?Q?f91H21ZbTk3pg9jOEy+CKV+dcZs2EMTWcgfshTqcvrNcGbAMUuIhOVYaHbyS?=
 =?us-ascii?Q?xj6EtVKSd1UwsKDVpk7cwy4tudH+0bjpAAU8hSyIf4+1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e9fea3d-8709-437e-bc6e-08db18ae763d
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 10:36:18.9708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /kaxwduTCcvEz6yY8Dl33VYIxfiQbeheI3OMuDVuUQFMGZ3/vghsPvBbXzCFhWbH/EimjSg37fMGZtTHTaSbMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4264
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 24 February 2023 23:26
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: linux-spi@vger.kernel.org; linux-tegra@vger.kernel.org; linux-
> kernel@vger.kernel.org; thierry.reding@gmail.com; Jonathan Hunter
> <jonathanh@nvidia.com>; Sowjanya Komatineni
> <skomatineni@nvidia.com>; Laxman Dewangan <ldewangan@nvidia.com>
> Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
>=20
> On Fri, Feb 24, 2023 at 04:50:00PM +0000, Krishna Yarlagadda wrote:
>=20
> > > >  		msg->actual_length +=3D xfer->len;
> > > > +		if (!xfer->cs_change && transfer_phase =3D=3D DATA_TRANSFER)
> > > {
> > > > +			tegra_qspi_transfer_end(spi);
> > > > +			spi_transfer_delay_exec(xfer);
> > > > +		}
> > > >  		transfer_phase++;
> > > >  	}
> > > > -	if (!xfer->cs_change) {
> > > > -		tegra_qspi_transfer_end(spi);
> > > > -		spi_transfer_delay_exec(xfer);
> > > > -	}
> updating the length of the message.
> > > This looks like it'll do the wrong thing and do a change on every
> > > transfer if cs_change isn't set?
>=20
> > This condition is hit only in data phase which is end of message.
>=20
> Shouldn't this just be moved into the DATA_TRANSFER case statement?
Calling transfer_end after updating message length.